Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2806)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/values-h720dp/dimens.xml

Issue 141853007: Update the AppBannerView appearance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another update for tablets Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/res/layout/app_banner_view.xml ('K') | « chrome/android/java/res/values-h720dp-v17/styles.xml ('k') | chrome/android/java/res/values-sw600dp-v17/styles.xml » ('j') | chrome/android/java/res/values-sw600dp-v17/styles.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/values-h720dp/dimens.xml
diff --git a/chrome/android/java/res/values-h720dp/dimens.xml b/chrome/android/java/res/values-h720dp/dimens.xml
new file mode 100644
index 0000000000000000000000000000000000000000..f5542d11181afda4914bec544d1997ff32745a6e
--- /dev/null
+++ b/chrome/android/java/res/values-h720dp/dimens.xml
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2014 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+
+<resources>
+ <!-- App banner dimensions -->
+ <dimen name="app_banner_max_width">570dp</dimen>
+ <dimen name="app_banner_margin_bottom">16dp</dimen>
+
+ <dimen name="app_banner_button_height">34dp</dimen>
newt (away) 2014/02/19 21:52:49 What if the system font size is HUGE? Is the butto
gone 2014/02/19 23:31:43 Made it define a min height instead.
+ <dimen name="app_banner_button_padding_sides">16dp</dimen>
+
+ <dimen name="app_banner_icon_size">112dp</dimen>
+ <dimen name="app_banner_icon_margin_end">16dp</dimen>
+
+ <dimen name="app_banner_text_margin_top">8dp</dimen>
+
+ <dimen name="app_banner_logo_height">30dp</dimen>
+ <dimen name="app_banner_logo_margin_bottom">2dp</dimen>
+
+ <dimen name="app_banner_star_height">20dp</dimen>
+</resources>
« chrome/android/java/res/layout/app_banner_view.xml ('K') | « chrome/android/java/res/values-h720dp-v17/styles.xml ('k') | chrome/android/java/res/values-sw600dp-v17/styles.xml » ('j') | chrome/android/java/res/values-sw600dp-v17/styles.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698