Chromium Code Reviews Chromium Code Reviews
Issue 141853007:
Update the AppBannerView appearance (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/android/java/res/layout/app_banner_view.xml |
| diff --git a/chrome/android/java/res/layout/app_banner_view.xml b/chrome/android/java/res/layout/app_banner_view.xml |
| index d12e7d5575c4d6a13a177da0ac141ae74bd63f31..bf0fbb25f51d4b6f020aa8df20f3b0ce3b3c1c64 100644 |
| --- a/chrome/android/java/res/layout/app_banner_view.xml |
| +++ b/chrome/android/java/res/layout/app_banner_view.xml |
| @@ -7,10 +7,9 @@ |
| <org.chromium.chrome.browser.banners.AppBannerView |
| xmlns:android="http://schemas.android.com/apk/res/android" |
| android:id="@+id/app_banner_view" |
| - android:background="@drawable/app_banner_background" |
| - android:layout_width="wrap_content" |
| - android:layout_height="wrap_content" |
| - android:layout_marginBottom="@dimen/app_banner_margin_bottom"> |
| + android:background="@drawable/card_background_default" |
|
newt (away)
2014/02/19 21:52:49
so you're just adding xxhdpi assets and letting An
gone
2014/02/19 23:31:43
Guess so, yeah. That's the only asset size the UX
|
| + android:layout_width="match_parent" |
| + android:layout_height="wrap_content"> |
| <ImageView |
| android:id="@+id/app_icon" |
| android:adjustViewBounds="true" |
| @@ -20,14 +19,17 @@ |
| <TextView |
| android:id="@+id/app_title" |
| android:textAppearance="@style/AppBannerTitle" |
| + android:includeFontPadding="false" |
| android:minLines="1" |
| + android:maxLines="1" |
| android:ellipsize="end" |
| android:layout_width="wrap_content" |
| android:layout_height="wrap_content" |
| - android:layout_marginTop="@dimen/app_banner_text_margin_top" /> |
| + android:layout_marginTop="@dimen/app_banner_text_margin_top" |
| + android:layout_marginBottom="@dimen/app_banner_text_margin_bottom" /> |
| <Button |
| android:id="@+id/app_install_button" |
| - android:background="@color/app_banner_install_button" |
| + android:background="@color/app_banner_install_button_bg" |
| android:text="Install" |
| android:textAppearance="@style/AppBannerInstallButton" |
| android:paddingStart="@dimen/app_banner_button_padding_sides" |
| @@ -36,16 +38,16 @@ |
| android:paddingBottom="@dimen/app_banner_button_padding_above_below" |
| android:layout_width="wrap_content" |
| android:layout_height="@dimen/app_banner_button_height" |
| - android:layout_marginTop="@dimen/app_banner_margin_full" |
| - android:layout_marginStart="@dimen/app_banner_margin_full" /> |
| + android:layout_marginTop="@dimen/app_banner_button_margin_top" |
| + android:layout_marginStart="@dimen/app_banner_button_margin_start" /> |
| <ImageView |
| android:id="@+id/store_logo" |
| - android:src="@drawable/google_play_logo" |
| + android:src="@drawable/logo_play_bw" |
|
newt (away)
2014/02/19 21:52:49
"google_play_logo" seems like a clearer name
gone
2014/02/19 23:31:43
Agreed -- renaming his asset.
|
| android:adjustViewBounds="true" |
| android:layout_width="wrap_content" |
| android:layout_height="@dimen/app_banner_logo_height" |
| android:layout_marginBottom="@dimen/app_banner_logo_margin_bottom" /> |
| - <ImageView |
| + <org.chromium.chrome.browser.banners.RatingView |
| android:id="@+id/app_rating" |
| android:adjustViewBounds="true" |
| android:layout_width="wrap_content" |
