chrome/android/java/res/values-h720dp/dimens.xml - Issue 141853007: Update the AppBannerView appearance

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values-h720dp/dimens.xml

Issue 141853007: Update the AppBannerView appearance (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another update for tablets Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6

	7 <resources>

	8 <!-- App banner dimensions -->

	9 <dimen name="app_banner_max_width">570dp</dimen>

	10 <dimen name="app_banner_margin_bottom">16dp</dimen>

	11

	12 <dimen name="app_banner_button_height">34dp</dimen>
	newt (away) 2014/02/19 21:52:49 What if the system font size is HUGE? Is the butto What if the system font size is HUGE? Is the button still big enough? You might be safer specifying the button height in sp, or just specifying the padding and letting the height be wrap_content. gone 2014/02/19 23:31:43 Made it define a min height instead. Show quoted text On 2014/02/19 21:52:49, newt wrote: > What if the system font size is HUGE? Is the button still big enough? You might > be safer specifying the button height in sp, or just specifying the padding and > letting the height be wrap_content. Made it define a min height instead.
	13 <dimen name="app_banner_button_padding_sides">16dp</dimen>

	14

	15 <dimen name="app_banner_icon_size">112dp</dimen>

	16 <dimen name="app_banner_icon_margin_end">16dp</dimen>

	17

	18 <dimen name="app_banner_text_margin_top">8dp</dimen>

	19

	20 <dimen name="app_banner_logo_height">30dp</dimen>

	21 <dimen name="app_banner_logo_margin_bottom">2dp</dimen>

	22

	23 <dimen name="app_banner_star_height">20dp</dimen>

	24 </resources>

OLD	NEW