Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: media/renderers/skcanvas_video_renderer.cc

Issue 1418513016: Revert of webgl: optimize webgl.texSubImage2D(video) path. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/renderers/skcanvas_video_renderer.h ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/renderers/skcanvas_video_renderer.cc
diff --git a/media/renderers/skcanvas_video_renderer.cc b/media/renderers/skcanvas_video_renderer.cc
index 59a87f9ecb05c49674e4d2183e328e460ae6efc6..7863a0d02e849dd37f966291df238755fdca696a 100644
--- a/media/renderers/skcanvas_video_renderer.cc
+++ b/media/renderers/skcanvas_video_renderer.cc
@@ -161,11 +161,8 @@
DCHECK(source_texture);
gl->BindTexture(GL_TEXTURE_2D, source_texture);
SkCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture(
- gl, video_frame,
- SkCanvasVideoRenderer::CopyFrameSingleTextureParams(
- SkCanvasVideoRenderer::CopyFrameSingleTextureParams::FullCopy,
- GL_TEXTURE_2D, source_texture, GL_RGBA, GL_UNSIGNED_BYTE, 0, 0, 0,
- true, false));
+ gl, video_frame, source_texture, GL_RGBA, GL_UNSIGNED_BYTE, true,
+ false);
} else {
gl->WaitSyncPointCHROMIUM(mailbox_holder.sync_point);
source_texture = gl->CreateAndConsumeTextureCHROMIUM(
@@ -539,7 +536,11 @@
void SkCanvasVideoRenderer::CopyVideoFrameSingleTextureToGLTexture(
gpu::gles2::GLES2Interface* gl,
VideoFrame* video_frame,
- const CopyFrameSingleTextureParams& params) {
+ unsigned int texture,
+ unsigned int internal_format,
+ unsigned int type,
+ bool premultiply_alpha,
+ bool flip_y) {
DCHECK(video_frame);
DCHECK(video_frame->HasTextures());
DCHECK_EQ(1u, VideoFrame::NumPlanes(video_frame->format()));
@@ -560,20 +561,9 @@
// value down to get the expected result.
// "flip_y == true" means to reverse the video orientation while
// "flip_y == false" means to keep the intrinsic orientation.
- if (params.copy_type == CopyFrameSingleTextureParams::FullCopy) {
- DCHECK(!params.xoffset && !params.yoffset);
- gl->CopyTextureCHROMIUM(params.target, source_texture, params.texture,
- params.internal_format, params.type, params.flip_y,
- params.premultiply_alpha, false);
- } else {
- DCHECK_EQ(static_cast<unsigned int>(GL_FALSE), params.internal_format);
- DCHECK_EQ(static_cast<unsigned int>(GL_FALSE), params.type);
- gl->CopySubTextureCHROMIUM(params.target, source_texture, params.texture,
- params.xoffset, params.yoffset, 0, 0,
- video_frame->natural_size().width(),
- video_frame->natural_size().height(),
- params.flip_y, params.premultiply_alpha, false);
- }
+ gl->CopyTextureCHROMIUM(GL_TEXTURE_2D, source_texture, texture,
+ internal_format, type, flip_y, premultiply_alpha,
+ false);
gl->DeleteTextures(1, &source_texture);
gl->Flush();
@@ -588,26 +578,4 @@
last_timestamp_ = kNoTimestamp();
}
-SkCanvasVideoRenderer::CopyFrameSingleTextureParams::
- CopyFrameSingleTextureParams(CopyType copy_type,
- unsigned target,
- unsigned texture,
- unsigned internal_format,
- unsigned type,
- int level,
- int xoffset,
- int yoffset,
- bool premultiply_alpha,
- bool flip_y)
- : copy_type(copy_type),
- target(target),
- texture(texture),
- internal_format(internal_format),
- type(type),
- level(level),
- xoffset(xoffset),
- yoffset(yoffset),
- premultiply_alpha(premultiply_alpha),
- flip_y(flip_y) {}
-
} // namespace media
« no previous file with comments | « media/renderers/skcanvas_video_renderer.h ('k') | third_party/WebKit/Source/core/html/HTMLVideoElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698