Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1418503007: Manual rebaseline for r355526 https://codereview.chromium.org/1413573004/ (Closed)

Created:
5 years, 2 months ago by mstensho (USE GERRIT)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual rebaseline for r355526 https://codereview.chromium.org/1413573004/ Re-mark some tests as crashing for Windows 10. Had to temporarily comment them out to get the rebaselining working. Or at least so I think. BUG=544786 TBR=leviw@chromium.org Committed: https://crrev.com/74dada5c834104ba60fa4ebdc4a0a0b943a9e733 Cr-Commit-Position: refs/heads/master@{#355616}

Patch Set 1 : This is what I got when I did webkit-patch rebaseline-expectations on the tests that I had marked with NeedsManualRebaseline in r355526. #

Patch Set 2 : No pixel result changes expected. Remove new PNG files. Also use --no-find-copies #

Patch Set 3 : More trimming. virtual/threaded/ expectations are the same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -288 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squashing-print-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/iframe-print-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/iframe-print-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/printing/forced-break-tree-dump-only-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/printing/iframe-print-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/iframe-print-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win-xp/printing/forced-break-tree-dump-only-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win-xp/printing/iframe-print-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win-xp/virtual/threaded/printing/iframe-print-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/printing/forced-break-tree-dump-only-expected.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/printing/iframe-print-expected.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/iframe-print-expected.txt View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/printing/iframe-print-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/iframe-print-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/LayoutTests/printing/simultaneous-position-float-change-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/threaded/printing/simultaneous-position-float-change-expected.txt View 1 2 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mstensho (USE GERRIT)
5 years, 2 months ago (2015-10-22 19:36:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418503007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418503007/40001
5 years, 2 months ago (2015-10-22 19:36:55 UTC) #3
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-22 19:45:44 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 19:47:14 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/74dada5c834104ba60fa4ebdc4a0a0b943a9e733
Cr-Commit-Position: refs/heads/master@{#355616}

Powered by Google App Engine
This is Rietveld 408576698