Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1418453011: [mips64] Support for mips n64 (Closed)

Created:
5 years, 1 month ago by mveljko
Modified:
4 years, 10 months ago
CC:
google-breakpad-dev_googlegroups.com, gordana.cmiljanovic_imgtec.com, paul.l..., petar.jovanovic, Paul Lind
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[mips64] Support for mips n64 Adding remaining mips n64 support including stackwalker. BUG=None TEST=manually tested on Linux/Android R=vapier@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/79556b7ca86baf84cbd29f69e7968f8e7a722f78

Patch Set 1 #

Total comments: 10

Patch Set 2 : addressing comments #

Total comments: 4

Patch Set 3 : Rebase #

Patch Set 4 : Rebase with Makefile change #

Total comments: 2

Patch Set 5 : Rebase on commit 83f0e6a31cd7e86e36a2a33085e86f8cc2a6fa7b #

Patch Set 6 : Fix accidentally removed lines from Makefile.am #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -191 lines) Patch
M Makefile.am View 1 2 3 4 5 2 chunks +11 lines, -0 lines 0 comments Download
M src/client/linux/dump_writer_common/thread_info.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/client/linux/dump_writer_common/ucontext_reader.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/client/linux/microdump_writer/microdump_writer.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/common/android/include/sys/procfs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_mips.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_format.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/dump_context.cc View 1 2 5 chunks +7 lines, -2 lines 0 comments Download
M src/processor/minidump.cc View 1 2 3 chunks +10 lines, -1 line 0 comments Download
M src/processor/minidump_processor.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/processor/processor.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/stackwalk_common.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/processor/stackwalker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/stackwalker_mips.cc View 5 chunks +274 lines, -126 lines 0 comments Download
A + src/processor/stackwalker_mips64_unittest.cc View 17 chunks +80 lines, -58 lines 0 comments Download
M src/processor/stackwalker_mips_unittest.cc View 10 chunks +10 lines, -0 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 23 (6 generated)
mveljko
Please, take a look at the changes.
5 years, 1 month ago (2015-11-09 13:50:46 UTC) #3
mveljko
On 2015/11/09 13:50:46, mveljko wrote: > Please, take a look at the changes. Just a ...
5 years, 1 month ago (2015-11-18 09:52:25 UTC) #4
Mark Mentovai
I don’t think I’m going to be able to review this in the next couple ...
5 years, 1 month ago (2015-11-18 14:30:49 UTC) #5
Mark Mentovai
Have your colleagues like Gordana that have submitted MIPS patches in the past had a ...
5 years, 1 month ago (2015-11-18 14:31:38 UTC) #6
gordanac
On 2015/11/18 14:31:38, Mark Mentovai wrote: > Have your colleagues like Gordana that have submitted ...
5 years, 1 month ago (2015-11-18 15:49:01 UTC) #7
Mark Mentovai
We could open it up to any interested committer on google-breakpad-dev.
5 years, 1 month ago (2015-11-18 15:55:11 UTC) #8
vapier
please clarify the commit message that you're adding support only for o64 here and not ...
5 years ago (2015-12-15 17:29:27 UTC) #11
mveljko
Updated code, based on comments. https://codereview.chromium.org/1418453011/diff/1/src/client/linux/dump_writer_common/thread_info.cc File src/client/linux/dump_writer_common/thread_info.cc (right): https://codereview.chromium.org/1418453011/diff/1/src/client/linux/dump_writer_common/thread_info.cc#newcode240 src/client/linux/dump_writer_common/thread_info.cc:240: #else On 2015/12/15 17:29:27, ...
5 years ago (2015-12-17 13:36:25 UTC) #12
mveljko
On 2015/12/17 13:36:25, mveljko wrote: > Updated code, based on comments. > > https://codereview.chromium.org/1418453011/diff/1/src/client/linux/dump_writer_common/thread_info.cc > ...
4 years, 10 months ago (2016-02-01 10:02:25 UTC) #14
vapier
i've lightly glanced at the mips-specific parts and nothing catches my eye. i'll defer to ...
4 years, 10 months ago (2016-02-01 22:43:42 UTC) #15
mveljko
https://codereview.chromium.org/1418453011/diff/20001/Makefile.am File Makefile.am (right): https://codereview.chromium.org/1418453011/diff/20001/Makefile.am#newcode1152 Makefile.am:1152: src/testing/gtest/src/gtest-all.cc \ On 2016/02/01 22:43:42, vapier wrote: > you ...
4 years, 10 months ago (2016-02-04 14:32:24 UTC) #16
mveljko
On 2016/02/01 22:43:42, vapier wrote: > i've lightly glanced at the mips-specific parts and nothing ...
4 years, 10 months ago (2016-02-04 14:47:46 UTC) #17
vapier
https://codereview.chromium.org/1418453011/diff/60001/Makefile.am File Makefile.am (right): https://codereview.chromium.org/1418453011/diff/60001/Makefile.am#newcode1059 Makefile.am:1059: src/testing/gtest/src/gtest-all.cc \ doesn't seem like you updated properly ...
4 years, 10 months ago (2016-02-04 18:30:59 UTC) #18
mveljko
https://codereview.chromium.org/1418453011/diff/60001/Makefile.am File Makefile.am (right): https://codereview.chromium.org/1418453011/diff/60001/Makefile.am#newcode1059 Makefile.am:1059: src/testing/gtest/src/gtest-all.cc \ On 2016/02/04 18:30:59, vapier wrote: > doesn't ...
4 years, 10 months ago (2016-02-05 09:45:32 UTC) #19
mveljko
On 2016/02/04 18:30:59, vapier wrote: > https://codereview.chromium.org/1418453011/diff/60001/Makefile.am > File Makefile.am (right): > > https://codereview.chromium.org/1418453011/diff/60001/Makefile.am#newcode1059 > ...
4 years, 10 months ago (2016-02-05 09:46:25 UTC) #20
vapier
lgtm
4 years, 10 months ago (2016-02-05 17:52:24 UTC) #21
vapier
4 years, 10 months ago (2016-02-06 23:58:45 UTC) #23
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
79556b7ca86baf84cbd29f69e7968f8e7a722f78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698