Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2014, Google Inc. | 1 // Copyright (c) 2014, Google Inc. |
| 2 // All rights reserved. | 2 // All rights reserved. |
| 3 // | 3 // |
| 4 // Redistribution and use in source and binary forms, with or without | 4 // Redistribution and use in source and binary forms, with or without |
| 5 // modification, are permitted provided that the following conditions are | 5 // modification, are permitted provided that the following conditions are |
| 6 // met: | 6 // met: |
| 7 // | 7 // |
| 8 // * Redistributions of source code must retain the above copyright | 8 // * Redistributions of source code must retain the above copyright |
| 9 // notice, this list of conditions and the following disclaimer. | 9 // notice, this list of conditions and the following disclaimer. |
| 10 // * Redistributions in binary form must reproduce the above | 10 // * Redistributions in binary form must reproduce the above |
| (...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 171 // hw architecture (the one returned by uname()), for instance in the case of | 171 // hw architecture (the one returned by uname()), for instance in the case of |
| 172 // a 32-bit app running on a aarch64 device. | 172 // a 32-bit app running on a aarch64 device. |
| 173 #if defined(__aarch64__) | 173 #if defined(__aarch64__) |
| 174 const char kArch[] = "arm64"; | 174 const char kArch[] = "arm64"; |
| 175 #elif defined(__ARMEL__) | 175 #elif defined(__ARMEL__) |
| 176 const char kArch[] = "arm"; | 176 const char kArch[] = "arm"; |
| 177 #elif defined(__x86_64__) | 177 #elif defined(__x86_64__) |
| 178 const char kArch[] = "x86_64"; | 178 const char kArch[] = "x86_64"; |
| 179 #elif defined(__i386__) | 179 #elif defined(__i386__) |
| 180 const char kArch[] = "x86"; | 180 const char kArch[] = "x86"; |
| 181 #elif defined(__mips__) | 181 #elif defined(__mips__) && _MIPS_SIM == _ABIO32 |
|
vapier
2015/12/15 17:29:27
would be cleaner imo to write:
#if defined(__mips
mveljko
2015/12/17 13:36:24
Done.
| |
| 182 const char kArch[] = "mips"; | 182 const char kArch[] = "mips"; |
| 183 #elif defined(__mips__) && _MIPS_SIM == _ABI64 | |
| 184 const char kArch[] = "mips64"; | |
| 183 #else | 185 #else |
| 184 #error "This code has not been ported to your platform yet" | 186 #error "This code has not been ported to your platform yet" |
| 185 #endif | 187 #endif |
| 186 | 188 |
| 187 LogAppend("O "); | 189 LogAppend("O "); |
| 188 LogAppend(kOSId); | 190 LogAppend(kOSId); |
| 189 LogAppend(" "); | 191 LogAppend(" "); |
| 190 LogAppend(kArch); | 192 LogAppend(kArch); |
| 191 LogAppend(" "); | 193 LogAppend(" "); |
| 192 LogAppend(n_cpus); | 194 LogAppend(n_cpus); |
| (...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 424 dumper.set_crash_signal(context->siginfo.si_signo); | 426 dumper.set_crash_signal(context->siginfo.si_signo); |
| 425 dumper.set_crash_thread(context->tid); | 427 dumper.set_crash_thread(context->tid); |
| 426 } | 428 } |
| 427 MicrodumpWriter writer(context, mappings, microdump_extra_info, &dumper); | 429 MicrodumpWriter writer(context, mappings, microdump_extra_info, &dumper); |
| 428 if (!writer.Init()) | 430 if (!writer.Init()) |
| 429 return false; | 431 return false; |
| 430 return writer.Dump(); | 432 return writer.Dump(); |
| 431 } | 433 } |
| 432 | 434 |
| 433 } // namespace google_breakpad | 435 } // namespace google_breakpad |
| OLD | NEW |