Notification custom layouts: spacing of the timestamp.

Notification custom layouts: spacing of the timestamp.

Fixes spacing in Material (Holo will come later).

BUG=541617
Committed: https://crrev.com/2a71fe7b6afd5b8c35b102099e706a949a4d9e43
Cr-Commit-Position: refs/heads/master@{#357075}

[Michael van Ouwerkerk, 2015-10-29 12:40:03]

mvanouwerkerk@chromium.org changed reviewers:
+ newt@chromium.org, peter@chromium.org

[Michael van Ouwerkerk, 2015-10-29 12:40:03]

Peter and Newton, could you take a look please? This is just the styling part of
https://codereview.chromium.org/1412483006/.

[Peter Beverloo, 2015-10-29 14:29:24]

lgtm

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification.xml (right):

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification.xml:43:
android:layout_alignBaseline="@id/title"
nit: Please group the align* attributes together.

Perhaps we should keep the attributes alphabetically ordered? It's rather
randomized per instance now :)

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification_big.xml (right):

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification_big.xml:67:
android:layout_alignBaseline="@id/title"
dito

[Michael van Ouwerkerk, 2015-10-29 17:08:40]

Thanks!

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification.xml (right):

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification.xml:43:
android:layout_alignBaseline="@id/title"
On 2015/10/29 14:29:24, Peter Beverloo wrote:
> nit: Please group the align* attributes together.
> 
> Perhaps we should keep the attributes alphabetically ordered? It's rather
> randomized per instance now :)

Done.

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/web_notification_big.xml (right):

https://codereview.chromium.org/1418453003/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/web_notification_big.xml:67:
android:layout_alignBaseline="@id/title"
On 2015/10/29 14:29:24, Peter Beverloo wrote:
> dito

Done.

[newt (away), 2015-10-29 20:38:19]

lgtm

https://codereview.chromium.org/1418453003/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/web_notification_big.xml (right):

https://codereview.chromium.org/1418453003/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/web_notification_big.xml:63:
android:layout_height="wrap_content"
Since we're talking about it, the attribute order that we use more or less
throughout Chrome is:

  id
  layout_width
  layout_height
  other layout_* attributes (alphabetized, or just "logically" arranged)
  other attributes (usually alphabetized)

Rationale:
width and height come first after id, since they're mandatory unlike other
attributes. layout_* attributes are grouped together because they are
instructions for the parent ViewGroup rather than for the view itself.

[Michael van Ouwerkerk, 2015-10-30 09:58:39]

Thanks for the quick reviews.

https://codereview.chromium.org/1418453003/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/web_notification_big.xml (right):

https://codereview.chromium.org/1418453003/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/web_notification_big.xml:63:
android:layout_height="wrap_content"
On 2015/10/29 20:38:19, newt wrote:
> Since we're talking about it, the attribute order that we use more or less
> throughout Chrome is:
> 
>   id
>   layout_width
>   layout_height
>   other layout_* attributes (alphabetized, or just "logically" arranged)
>   other attributes (usually alphabetized)
> 
> Rationale:
> width and height come first after id, since they're mandatory unlike other
> attributes. layout_* attributes are grouped together because they are
> instructions for the parent ViewGroup rather than for the view itself.

Thanks! That seems reasonable, I'll converge on this pattern as I make changes
then. Done for the parts touched by this CL.

[Michael van Ouwerkerk, 2015-10-30 09:58:43]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2015-10-30 09:58:44]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org,
newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1418453003/#ps40001
(title: "Address newt's comment on attribute ordering.")

[commit-bot: I haz the power, 2015-10-30 09:59:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1418453003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1418453003/40001

[commit-bot: I haz the power, 2015-10-30 10:36:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 10:37:39]

Patchset 3 (id:??) landed as
https://crrev.com/2a71fe7b6afd5b8c35b102099e706a949a4d9e43
Cr-Commit-Position: refs/heads/master@{#357075}