Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <!-- | 6 <!-- |
| 7 Web notification custom layout. | 7 Web notification custom layout. |
| 8 _______________________________________________________ | 8 _______________________________________________________ |
| 9 | | | | 9 | | | |
| 10 | Icon | Title text 1:23 pm | | 10 | Icon | Title text 1:23 pm | |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 android:singleLine="true" | 30 android:singleLine="true" |
| 31 android:ellipsize="end" | 31 android:ellipsize="end" |
| 32 style="@style/WebNotificationTitle"/> | 32 style="@style/WebNotificationTitle"/> |
| 33 | 33 |
| 34 <TextView | 34 <TextView |
| 35 android:id="@+id/time" | 35 android:id="@+id/time" |
| 36 android:layout_width="wrap_content" | 36 android:layout_width="wrap_content" |
| 37 android:layout_height="wrap_content" | 37 android:layout_height="wrap_content" |
| 38 android:layout_alignParentEnd="true" | 38 android:layout_alignParentEnd="true" |
| 39 android:layout_alignParentTop="true" | 39 android:layout_alignParentTop="true" |
| 40 android:layout_marginStart="8dp" | |
| 41 android:layout_marginEnd="8dp" | |
| 42 android:layout_marginTop="8dp" | |
| 43 android:layout_alignBaseline="@id/title" | |
|
Peter Beverloo
2015/10/29 14:29:24
nit: Please group the align* attributes together.
Michael van Ouwerkerk
2015/10/29 17:08:40
Done.
| |
| 40 android:singleLine="true" | 44 android:singleLine="true" |
| 41 style="@style/WebNotificationTime"/> | 45 style="@style/WebNotificationTime"/> |
| 42 | 46 |
| 43 <TextView | 47 <TextView |
| 44 android:id="@+id/body" | 48 android:id="@+id/body" |
| 45 android:layout_width="wrap_content" | 49 android:layout_width="wrap_content" |
| 46 android:layout_height="wrap_content" | 50 android:layout_height="wrap_content" |
| 47 android:layout_toEndOf="@id/icon_frame" | 51 android:layout_toEndOf="@id/icon_frame" |
| 48 android:layout_alignParentEnd="true" | 52 android:layout_alignParentEnd="true" |
| 49 android:layout_below="@id/title" | 53 android:layout_below="@id/title" |
| 50 android:layout_marginTop="-1dp" | 54 android:layout_marginTop="-1dp" |
| 51 android:layout_marginBottom="-1dp" | 55 android:layout_marginBottom="-1dp" |
| 52 android:layout_marginEnd="6dp" | 56 android:layout_marginEnd="6dp" |
| 53 android:singleLine="true" | 57 android:singleLine="true" |
| 54 android:ellipsize="end" | 58 android:ellipsize="end" |
| 55 style="@style/WebNotificationBody"/> | 59 style="@style/WebNotificationBody"/> |
| 56 | 60 |
| 57 <TextView | 61 <TextView |
| 58 android:id="@+id/origin" | 62 android:id="@+id/origin" |
| 59 android:layout_width="wrap_content" | 63 android:layout_width="wrap_content" |
| 60 android:layout_height="wrap_content" | 64 android:layout_height="wrap_content" |
| 61 android:layout_toEndOf="@id/icon_frame" | 65 android:layout_toEndOf="@id/icon_frame" |
| 62 android:layout_alignParentEnd="true" | 66 android:layout_alignParentEnd="true" |
| 63 android:layout_below="@id/body" | 67 android:layout_below="@id/body" |
| 64 android:singleLine="true" | 68 android:singleLine="true" |
| 65 android:ellipsize="end" | 69 android:ellipsize="end" |
| 66 style="@style/WebNotificationOrigin"/> | 70 style="@style/WebNotificationOrigin"/> |
| 67 | 71 |
| 68 </RelativeLayout> | 72 </RelativeLayout> |
| OLD | NEW |