Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: chrome/android/java/res/layout/web_notification_big.xml

Issue 1418453003: Notification custom layouts: spacing of the timestamp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Alphabetize the attributes. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/web_notification.xml ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Web notification custom layout, big state. 7 Web notification custom layout, big state.
8 _______________________________________________________ 8 _______________________________________________________
9 | | | 9 | | |
10 | Icon | Title text 1:23 pm | 10 | Icon | Title text 1:23 pm |
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 android:layout_height="wrap_content" 50 android:layout_height="wrap_content"
51 android:layout_alignParentStart="true" 51 android:layout_alignParentStart="true"
52 android:layout_toStartOf="@id/time" 52 android:layout_toStartOf="@id/time"
53 android:layout_alignParentTop="true" 53 android:layout_alignParentTop="true"
54 android:layout_marginTop="4dp" 54 android:layout_marginTop="4dp"
55 android:singleLine="true" 55 android:singleLine="true"
56 android:ellipsize="end"/> 56 android:ellipsize="end"/>
57 57
58 <TextView 58 <TextView
59 android:id="@+id/time" 59 android:id="@+id/time"
60 style="@style/WebNotificationTime" 60 android:layout_alignBaseline="@id/title"
61 android:layout_width="wrap_content"
62 android:layout_height="wrap_content"
63 android:layout_alignParentEnd="true" 61 android:layout_alignParentEnd="true"
64 android:layout_alignParentTop="true" 62 android:layout_alignParentTop="true"
65 android:singleLine="true"/> 63 android:layout_height="wrap_content"
newt (away) 2015/10/29 20:38:19 Since we're talking about it, the attribute order
Michael van Ouwerkerk 2015/10/30 09:58:39 Thanks! That seems reasonable, I'll converge on th
64 android:layout_width="wrap_content"
65 android:layout_marginEnd="8dp"
66 android:layout_marginStart="8dp"
67 android:layout_marginTop="8dp"
68 android:singleLine="true"
69 style="@style/WebNotificationTime"/>
66 70
67 </RelativeLayout> 71 </RelativeLayout>
68 72
69 <TextView 73 <TextView
70 android:id="@+id/body" 74 android:id="@+id/body"
71 style="@style/WebNotificationBodyBig" 75 style="@style/WebNotificationBodyBig"
72 android:layout_width="wrap_content" 76 android:layout_width="wrap_content"
73 android:layout_height="wrap_content" 77 android:layout_height="wrap_content"
74 android:layout_marginEnd="6dp" 78 android:layout_marginEnd="6dp"
75 android:layout_marginBottom="8dp" 79 android:layout_marginBottom="8dp"
(...skipping 30 matching lines...) Expand all
106 style="@style/WebNotificationOrigin" 110 style="@style/WebNotificationOrigin"
107 android:layout_width="match_parent" 111 android:layout_width="match_parent"
108 android:layout_height="wrap_content" 112 android:layout_height="wrap_content"
109 android:layout_marginBottom="10dp" 113 android:layout_marginBottom="10dp"
110 android:singleLine="true" 114 android:singleLine="true"
111 android:ellipsize="end"/> 115 android:ellipsize="end"/>
112 116
113 </LinearLayout> 117 </LinearLayout>
114 118
115 </RelativeLayout> 119 </RelativeLayout>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/web_notification.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698