Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1418193007: Web Animations: Add SVGNumberOptionalNumberInterpolationType (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgIntegerInterpolationType
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Add SVGNumberOptionalNumberInterpolationType This change migrates the following SVG attribute animations over to SVGNumberOptionalNumberInterpolationType and enables additive keyframe composite modes as well as neutral keyframes: - baseFrequency - kernelUnitLength - radius - stdDeviation This is a rebased reupload of: https://codereview.chromium.org/1419623009 BUG=530436 Committed: https://crrev.com/2d71e80d4e4faf90ee7f507dc2b57f0ea562b874 Cr-Commit-Position: refs/heads/master@{#361281}

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Rebased #

Patch Set 4 : neutralKeyframe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+619 lines, -68 lines) Patch
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-baseFrequency-composition.html View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-kernelUnitLength-composition.html View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-radius-composition.html View 1 2 3 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-stdDeviation-composition.html View 1 2 3 1 chunk +145 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/animation/NumberOptionalNumberSVGInterpolation.h View 1 chunk +0 lines, -54 lines 0 comments Download
A + third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.h View 1 chunk +5 lines, -8 lines 0 comments Download
A third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp View 1 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 4 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.h View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1416703004 Patch 120001

Messages

Total messages: 36 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/40001
5 years, 1 month ago (2015-11-17 04:03:31 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/95322) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-17 04:07:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/40001
5 years, 1 month ago (2015-11-17 07:17:25 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/95375) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-17 07:21:42 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/40001
5 years, 1 month ago (2015-11-18 00:27:48 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 02:31:56 UTC) #12
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-18 09:11:03 UTC) #14
Eric Willigers
lgtm
5 years, 1 month ago (2015-11-20 02:35:17 UTC) #15
dstockwell
lgtm
5 years, 1 month ago (2015-11-23 04:53:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/40001
5 years, 1 month ago (2015-11-23 05:39:45 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/144448)
5 years, 1 month ago (2015-11-23 06:55:02 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/60001
5 years, 1 month ago (2015-11-23 22:04:03 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133091)
5 years, 1 month ago (2015-11-23 23:57:51 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/60001
5 years, 1 month ago (2015-11-24 00:11:27 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133246)
5 years, 1 month ago (2015-11-24 03:12:47 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/60001
5 years ago (2015-11-24 06:00:54 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418193007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418193007/60001
5 years ago (2015-11-24 07:20:31 UTC) #34
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-24 08:07:32 UTC) #35
commit-bot: I haz the power
5 years ago (2015-11-24 08:08:16 UTC) #36
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2d71e80d4e4faf90ee7f507dc2b57f0ea562b874
Cr-Commit-Position: refs/heads/master@{#361281}

Powered by Google App Engine
This is Rietveld 408576698