Issue 1419623009: SVG Web Animations: Add SVGNumberOptionalNumberInterpolationType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1419623009: SVG Web Animations: Add SVGNumberOptionalNumberInterpolationType (Closed)

Created:
5 years, 1 month ago by sashab

Modified:
5 years ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, krit, f(malita), darktears, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

SVG Web Animations: Add SVGNumberOptionalNumberInterpolationType This change adds SVGNumberOptionalNumberInterpolationType for the order attribute, replacing the legacy pipeline that used NumberOptionalNumberSVGInterpolation. BUG=530436

Patch Set 1 #

Patch Set 2 : Fix tests #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+636 lines, -68 lines)			Patch
A	third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-baseFrequency-composition.html	View	1	1 chunk	+141 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-kernelUnitLength-composition.html	View	1	1 chunk	+141 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-radius-composition.html	View	1	1 chunk	+141 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/animations/svg-attribute-composition/svg-stdDeviation-composition.html	View	1	1 chunk	+147 lines, -0 lines	0 comments	Download
D	third_party/WebKit/Source/core/animation/NumberOptionalNumberSVGInterpolation.h	View		1 chunk	+0 lines, -54 lines	0 comments	Download
A +	third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.h	View		2 chunks	+5 lines, -8 lines	0 comments	Download
A	third_party/WebKit/Source/core/animation/SVGNumberOptionalNumberInterpolationType.cpp	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/animation/StringKeyframe.cpp	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/core.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dstockwell please review stuff in svg/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages