Add type cast definitions for CPDF_Name.

Add type cast definitions for CPDF_Name.

This Cl adds ToName, CPDF_Object::AsName and CPDF_Object::IsName and
updates the src to use them as needed.

BUG=pdfium:201
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/1c77edb7b34e03787605b7965784cea38ef9f1d7

[dsinclair, 2015-10-21 16:55:48]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-21 16:55:49]

PTAL.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfdoc/doc_tagged...
File core/src/fpdfdoc/doc_tagged.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfdoc/doc_tagged...
core/src/fpdfdoc/doc_tagged.cpp:420: if (ToName(pAttr))
I tried making this one line but it generates build errors. default_value is
const and GetString is non-const and the compiler doesn't like having two
differing types in there.

[Lei Zhang, 2015-10-21 16:59:04]

https://codereview.chromium.org/1417823005/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:851: if ((pValueObj->GetType() ==
PDFOBJ_STRING) || pValueObj->IsName())
Isn't this just going to conflict with the string CL? Let's land the other one
first, rebase, and then review.

[Tom Sepez, 2015-10-21 17:26:18]

LGTM with nits.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp:1210: if (subtype ==
FX_BSTRC("CIDFontType0"))
nit: m_bType1 = (subtype == FX_BSTRC(...));

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp:513: if (pObject &&
!pObject->IsName())
nit: maybe use ? operator.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp:91: 
nit: blank not really needed here.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:73:
pName->m_Name.GetLength());
nit: same comment as thestig in last cl about maybe making a local to hold
->m_Name.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:329: 
nit: I might have not opted for the ? operator here for parallelism with the
above |if|s.  we're going to have a bunch of statements of the form
   if (CPDF_Mumble* pMumble = AsMumble()) { 
      return pMumble->Fribits();
   }
   ...
   return CFX_Widestring();

[dsinclair, 2015-10-21 17:52:41]

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp:1210: if (subtype ==
FX_BSTRC("CIDFontType0"))
On 2015/10/21 17:26:17, Tom Sepez wrote:
> nit: m_bType1 = (subtype == FX_BSTRC(...));

Done.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp:513: if (pObject &&
!pObject->IsName())
On 2015/10/21 17:26:17, Tom Sepez wrote:
> nit: maybe use ? operator.

Done.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp:91: 
On 2015/10/21 17:26:17, Tom Sepez wrote:
> nit: blank not really needed here.

Done.

Added since I though it was a bit easier to read.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:73:
pName->m_Name.GetLength());
On 2015/10/21 17:26:18, Tom Sepez wrote:
> nit: same comment as thestig in last cl about maybe making a local to hold
> ->m_Name.

Done.

https://codereview.chromium.org/1417823005/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:329: 
On 2015/10/21 17:26:17, Tom Sepez wrote:
> nit: I might have not opted for the ? operator here for parallelism with the
> above |if|s.  we're going to have a bunch of statements of the form
>    if (CPDF_Mumble* pMumble = AsMumble()) { 
>       return pMumble->Fribits();
>    }
>    ...
>    return CFX_Widestring();

Done.

https://codereview.chromium.org/1417823005/diff/1/fpdfsdk/src/javascript/Docu...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1417823005/diff/1/fpdfsdk/src/javascript/Docu...
fpdfsdk/src/javascript/Document.cpp:851: if ((pValueObj->GetType() ==
PDFOBJ_STRING) || pValueObj->IsName())
On 2015/10/21 16:59:04, Lei Zhang wrote:
> Isn't this just going to conflict with the string CL? Let's land the other one
> first, rebase, and then review.

Acknowledged.

[dsinclair, 2015-10-21 17:55:42]

Committed patchset #3 (id:40001) manually as
1c77edb7b34e03787605b7965784cea38ef9f1d7 (presubmit successful).