core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp - Issue 1417823005: Add type cast definitions for CPDF_Name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

Issue 1417823005: Add type cast definitions for CPDF_Name. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

index d9a745393a8372fbda098b3bde45157e41201a9b..514380eeab7cc8e9b1168f244bc454ece8d2eb02 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp

@@ -3807,8 +3807,9 @@ int32_t CPDF_DataAvail::CheckCrossRefStream(IFX_DownloadHints* pHints,

return 0;

}

CPDF_Dictionary* pDict = pObj->GetDict();

- CPDF_Object* pName = pDict ? pDict->GetElement(FX_BSTRC("Type")) : NULL;

- if (pName && pName->GetType() == PDFOBJ_NAME) {

+ CPDF_Name* pName =

+ ToName(pDict ? pDict->GetElement(FX_BSTRC("Type")) : nullptr);

+ if (pName) {

if (pName->GetString() == FX_BSTRC("XRef")) {

m_Pos += m_parser.m_Syntax.SavePos();

xref_offset = pObj->GetDict()->GetInteger(FX_BSTRC("Prev"));