Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: fpdfsdk/src/fpdfppo.cpp

Issue 1417823005: Add type cast definitions for CPDF_Name. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/src/formfiller/FFL_Utils.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../public/fpdf_ppo.h" 7 #include "../../public/fpdf_ppo.h"
8 #include "../../third_party/base/nonstd_unique_ptr.h" 8 #include "../../third_party/base/nonstd_unique_ptr.h"
9 #include "../include/fsdk_define.h" 9 #include "../include/fsdk_define.h"
10 10
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 171
172 CPDF_Object* CPDF_PageOrganizer::PageDictGetInheritableTag( 172 CPDF_Object* CPDF_PageOrganizer::PageDictGetInheritableTag(
173 CPDF_Dictionary* pDict, 173 CPDF_Dictionary* pDict,
174 CFX_ByteString nSrctag) { 174 CFX_ByteString nSrctag) {
175 if (!pDict || nSrctag.IsEmpty()) 175 if (!pDict || nSrctag.IsEmpty())
176 return nullptr; 176 return nullptr;
177 if (!pDict->KeyExist("Parent") || !pDict->KeyExist("Type")) 177 if (!pDict->KeyExist("Parent") || !pDict->KeyExist("Type"))
178 return nullptr; 178 return nullptr;
179 179
180 CPDF_Object* pType = pDict->GetElement("Type")->GetDirect(); 180 CPDF_Object* pType = pDict->GetElement("Type")->GetDirect();
181 if (!pType || pType->GetType() != PDFOBJ_NAME) 181 if (!ToName(pType))
182 return nullptr; 182 return nullptr;
183 if (pType->GetString().Compare("Page")) 183 if (pType->GetString().Compare("Page"))
184 return nullptr; 184 return nullptr;
185 185
186 CPDF_Dictionary* pp = ToDictionary(pDict->GetElement("Parent")->GetDirect()); 186 CPDF_Dictionary* pp = ToDictionary(pDict->GetElement("Parent")->GetDirect());
187 if (!pp) 187 if (!pp)
188 return nullptr; 188 return nullptr;
189 189
190 if (pDict->KeyExist((const char*)nSrctag)) 190 if (pDict->KeyExist((const char*)nSrctag))
191 return pDict->GetElement((const char*)nSrctag); 191 return pDict->GetElement((const char*)nSrctag);
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 if (!pSrcDict) 402 if (!pSrcDict)
403 return FALSE; 403 return FALSE;
404 404
405 CPDF_Dictionary* pDstDict = pDstDoc->GetRoot(); 405 CPDF_Dictionary* pDstDict = pDstDoc->GetRoot();
406 if (!pDstDict) 406 if (!pDstDict)
407 return FALSE; 407 return FALSE;
408 408
409 pDstDict->SetAt(FX_BSTRC("ViewerPreferences"), pSrcDict->Clone(TRUE)); 409 pDstDict->SetAt(FX_BSTRC("ViewerPreferences"), pSrcDict->Clone(TRUE));
410 return TRUE; 410 return TRUE;
411 } 411 }
OLDNEW
« no previous file with comments | « fpdfsdk/src/formfiller/FFL_Utils.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698