Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1417753004: Reland Switch Chrome Android using v8 arch specific external data name (Closed)

Created:
5 years, 2 months ago by michaelbai
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, yfriedman+watch_chromium.org, halliwell+watch_chromium.org, blink-reviews, gunsch+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Orignal patch https://codereview.chromium.org/1400953002/ Switch Chrome Android using v8 arch specific external data name For 32-bit, natives_blob_32.bin and snapshot_blob_32.bin are used. For 64-bit, natives_blob_64.bin and natives_blob_64.bin are used. This patch also removed the existing v8 startup data in destination directory by using copy_ex to remove directory first. BUG=540788 TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org Committed: https://crrev.com/ed31140dee44c06e6398e92e1afb9c047c9137e6 Cr-Commit-Position: refs/heads/master@{#355843}

Patch Set 1 #

Patch Set 2 : fix html_viewer #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -134 lines) Patch
A build/android/v8_external_startup_data_arch_suffix.gypi View 1 chunk +18 lines, -0 lines 0 comments Download
M build_overrides/v8.gni View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/chrome_android_paks.gypi View 3 chunks +15 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +15 lines, -4 lines 0 comments Download
M components/components_tests.gyp View 1 2 2 chunks +22 lines, -13 lines 0 comments Download
M components/html_viewer/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/content.gyp View 1 chunk +27 lines, -29 lines 0 comments Download
M content/content_shell.gypi View 4 chunks +2 lines, -15 lines 0 comments Download
M content/content_tests.gypi View 5 chunks +22 lines, -17 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M gin/v8_initializer.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/net.gyp View 1 2 2 chunks +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform_tests.gyp View 2 chunks +19 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/web_tests.gyp View 2 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753004/20001
5 years, 2 months ago (2015-10-23 04:39:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/85168) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-23 04:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417753004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417753004/40001
5 years, 2 months ago (2015-10-23 16:37:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-23 18:46:18 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ed31140dee44c06e6398e92e1afb9c047c9137e6 Cr-Commit-Position: refs/heads/master@{#355843}
5 years, 2 months ago (2015-10-23 18:49:19 UTC) #9
jbudorick
5 years, 2 months ago (2015-10-23 20:51:31 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1421893002/ by jbudorick@chromium.org.

The reason for reverting is: broke gpu bots:
https://build.chromium.org/p/chromium.gpu/builders/Android%20Debug%20%28Nexus....

Powered by Google App Engine
This is Rietveld 408576698