chromecast/chromecast.gyp - Issue 1417753004: Reland Switch Chrome Android using v8 arch specific external data name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/chromecast.gyp

Issue 1417753004: Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/chromecast.gyp

diff --git a/chromecast/chromecast.gyp b/chromecast/chromecast.gyp

index e71e25ce2696d95755b8e793ebe7a70836cebced..4f5768452d692db3e4923098eab054238a39cf5d 100644

--- a/chromecast/chromecast.gyp

+++ b/chromecast/chromecast.gyp

@@ -546,14 +546,25 @@

'../third_party/icu/icu.gyp:icudata',

'../v8/tools/gyp/v8.gyp:v8_external_snapshot',

- 'copies': [{

- 'destination': '<(PRODUCT_DIR)/assets',

- 'files': [

+ 'variables': {

+ 'dest_path': '<(PRODUCT_DIR)/assets',

+ 'src_files': [

'<(PRODUCT_DIR)/icudtl.dat',

+ ],

+ 'renaming_sources': [

'<(PRODUCT_DIR)/natives_blob.bin',

'<(PRODUCT_DIR)/snapshot_blob.bin',

- }],

+ 'renaming_destinations': [

+ 'natives_blob_<(arch_suffix).bin',

+ 'snapshot_blob_<(arch_suffix).bin',

+ ],

+ 'clear': 1,

+ },

+ 'includes': [

+ '../build/android/copy_ex.gypi',

+ '../build/android/v8_external_startup_data_arch_suffix.gypi',

+ ],

{

'target_name': 'libcast_shell_android',

« no previous file with comments | « chrome/chrome_tests_unit.gypi ('k') | components/components_tests.gyp » ('j') | no next file with comments »