Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: net/net.gyp

Issue 1417753004: Reland Switch Chrome Android using v8 arch specific external data name (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/v8_initializer.cc ('k') | third_party/WebKit/Source/platform/blink_platform_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/net.gyp
diff --git a/net/net.gyp b/net/net.gyp
index f24751ffe03f012603e93b3706dbed6597f50fb5..d5193f6135baa9ad6cf67c40cb984bea1c1d194f 100644
--- a/net/net.gyp
+++ b/net/net.gyp
@@ -1520,15 +1520,19 @@
'dependencies': [
'../v8/tools/gyp/v8.gyp:v8_external_snapshot',
],
- 'copies': [
- {
- 'destination': '<(asset_location)',
- 'files': [
- '<(PRODUCT_DIR)/natives_blob.bin',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
- ],
- },
- ],
+ 'variables': {
+ 'dest_path': '<(asset_location)',
+ 'renaming_sources': [
+ '<(PRODUCT_DIR)/natives_blob.bin',
+ '<(PRODUCT_DIR)/snapshot_blob.bin',
+ ],
+ 'renaming_destinations': [
+ 'natives_blob_<(arch_suffix).bin',
+ 'snapshot_blob_<(arch_suffix).bin',
+ ],
+ 'clear': 1,
+ },
+ 'includes': ['../build/android/copy_ex.gypi'],
}],
],
'variables': {
@@ -1540,13 +1544,16 @@
['v8_use_external_startup_data==1', {
'asset_location': '<(PRODUCT_DIR)/net_unittests_apk/assets',
'additional_input_paths': [
- '<(PRODUCT_DIR)/net_unittests_apk/assets/natives_blob.bin',
- '<(PRODUCT_DIR)/net_unittests_apk/assets/snapshot_blob.bin',
+ '<(PRODUCT_DIR)/net_unittests_apk/assets/natives_blob_<(arch_suffix).bin',
+ '<(PRODUCT_DIR)/net_unittests_apk/assets/snapshot_blob_<(arch_suffix).bin',
],
}],
],
},
- 'includes': [ '../build/apk_test.gypi' ],
+ 'includes': [
+ '../build/apk_test.gypi',
+ '../build/android/v8_external_startup_data_arch_suffix.gypi',
+ ],
},
{
'target_name': 'net_junit_tests',
« no previous file with comments | « gin/v8_initializer.cc ('k') | third_party/WebKit/Source/platform/blink_platform_tests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698