Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417743007: [runtime] Drop redundant %CharFromCode runtime entry. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Drop redundant %CharFromCode runtime entry. The %StringCharFromCode and %CharFromCode runtime function perform exactly the same task, so we need only one of them. R=yangguo@chromium.org Committed: https://crrev.com/2b4cb2a14011404e7d20341bdc91d890a4584a18 Cr-Commit-Position: refs/heads/master@{#31873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-09 09:09:08 UTC) #1
Benedikt Meurer
Hey Yang, As discussed offline, simple cleanup. Please take a look. Thanks, Benedikt
5 years, 1 month ago (2015-11-09 09:09:40 UTC) #2
Yang
wow. lgtm.
5 years, 1 month ago (2015-11-09 09:15:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417743007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417743007/1
5 years, 1 month ago (2015-11-09 09:16:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 09:28:11 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 09:28:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2b4cb2a14011404e7d20341bdc91d890a4584a18
Cr-Commit-Position: refs/heads/master@{#31873}

Powered by Google App Engine
This is Rietveld 408576698