src/crankshaft/mips/lithium-codegen-mips.cc - Issue 1417743007: [runtime] Drop redundant %CharFromCode runtime entry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/mips/lithium-codegen-mips.cc

Issue 1417743007: [runtime] Drop redundant %CharFromCode runtime entry. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/mips/lithium-codegen-mips.cc

diff --git a/src/crankshaft/mips/lithium-codegen-mips.cc b/src/crankshaft/mips/lithium-codegen-mips.cc

index 3dba922f10a48c49864b0eb39ba8f448df6c26a7..6bac464210affcdef919d328e7b6d59afcc89422 100644

--- a/src/crankshaft/mips/lithium-codegen-mips.cc

+++ b/src/crankshaft/mips/lithium-codegen-mips.cc

@@ -4489,7 +4489,8 @@ void LCodeGen::DoDeferredStringCharFromCode(LStringCharFromCode* instr) {

PushSafepointRegistersScope scope(this);

__ SmiTag(char_code);

__ push(char_code);

- CallRuntimeFromDeferred(Runtime::kCharFromCode, 1, instr, instr->context());

+ CallRuntimeFromDeferred(Runtime::kStringCharFromCode, 1, instr,

+ instr->context());

__ StoreToSafepointRegisterSlot(v0, result);

}