Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/runtime/runtime-strings.cc

Issue 1417743007: [runtime] Drop redundant %CharFromCode runtime entry. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/conversions-inl.h" 8 #include "src/conversions-inl.h"
9 #include "src/isolate-inl.h" 9 #include "src/isolate-inl.h"
10 #include "src/regexp/jsregexp-inl.h" 10 #include "src/regexp/jsregexp-inl.h"
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 subject = String::Flatten(subject); 398 subject = String::Flatten(subject);
399 399
400 if (i >= static_cast<uint32_t>(subject->length())) { 400 if (i >= static_cast<uint32_t>(subject->length())) {
401 return isolate->heap()->nan_value(); 401 return isolate->heap()->nan_value();
402 } 402 }
403 403
404 return Smi::FromInt(subject->Get(i)); 404 return Smi::FromInt(subject->Get(i));
405 } 405 }
406 406
407 407
408 RUNTIME_FUNCTION(Runtime_CharFromCode) {
409 HandleScope handlescope(isolate);
410 DCHECK(args.length() == 1);
411 if (args[0]->IsNumber()) {
412 CONVERT_NUMBER_CHECKED(uint32_t, code, Uint32, args[0]);
413 code &= 0xffff;
414 return *isolate->factory()->LookupSingleCharacterStringFromCode(code);
415 }
416 return isolate->heap()->empty_string();
417 }
418
419
420 RUNTIME_FUNCTION(Runtime_StringCompare) { 408 RUNTIME_FUNCTION(Runtime_StringCompare) {
421 HandleScope handle_scope(isolate); 409 HandleScope handle_scope(isolate);
422 DCHECK_EQ(2, args.length()); 410 DCHECK_EQ(2, args.length());
423 CONVERT_ARG_HANDLE_CHECKED(String, x, 0); 411 CONVERT_ARG_HANDLE_CHECKED(String, x, 0);
424 CONVERT_ARG_HANDLE_CHECKED(String, y, 1); 412 CONVERT_ARG_HANDLE_CHECKED(String, y, 1);
425 isolate->counters()->string_compare_runtime()->Increment(); 413 isolate->counters()->string_compare_runtime()->Increment();
426 switch (String::Compare(x, y)) { 414 switch (String::Compare(x, y)) {
427 case ComparisonResult::kLessThan: 415 case ComparisonResult::kLessThan:
428 return Smi::FromInt(LESS); 416 return Smi::FromInt(LESS);
429 case ComparisonResult::kEqual: 417 case ComparisonResult::kEqual:
(...skipping 748 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 1166
1179 RUNTIME_FUNCTION(Runtime_FlattenString) { 1167 RUNTIME_FUNCTION(Runtime_FlattenString) {
1180 HandleScope scope(isolate); 1168 HandleScope scope(isolate);
1181 DCHECK(args.length() == 1); 1169 DCHECK(args.length() == 1);
1182 CONVERT_ARG_HANDLE_CHECKED(String, str, 0); 1170 CONVERT_ARG_HANDLE_CHECKED(String, str, 0);
1183 return *String::Flatten(str); 1171 return *String::Flatten(str);
1184 } 1172 }
1185 1173
1186 1174
1187 RUNTIME_FUNCTION(Runtime_StringCharFromCode) { 1175 RUNTIME_FUNCTION(Runtime_StringCharFromCode) {
1188 SealHandleScope shs(isolate); 1176 HandleScope handlescope(isolate);
1189 return __RT_impl_Runtime_CharFromCode(args, isolate); 1177 DCHECK_EQ(1, args.length());
1178 if (args[0]->IsNumber()) {
1179 CONVERT_NUMBER_CHECKED(uint32_t, code, Uint32, args[0]);
1180 code &= 0xffff;
1181 return *isolate->factory()->LookupSingleCharacterStringFromCode(code);
1182 }
1183 return isolate->heap()->empty_string();
1190 } 1184 }
1191 1185
1192 1186
1193 RUNTIME_FUNCTION(Runtime_StringCharAt) { 1187 RUNTIME_FUNCTION(Runtime_StringCharAt) {
1194 SealHandleScope shs(isolate); 1188 SealHandleScope shs(isolate);
1195 DCHECK(args.length() == 2); 1189 DCHECK(args.length() == 2);
1196 if (!args[0]->IsString()) return Smi::FromInt(0); 1190 if (!args[0]->IsString()) return Smi::FromInt(0);
1197 if (!args[1]->IsNumber()) return Smi::FromInt(0); 1191 if (!args[1]->IsNumber()) return Smi::FromInt(0);
1198 if (std::isinf(args.number_at(1))) return isolate->heap()->empty_string(); 1192 if (std::isinf(args.number_at(1))) return isolate->heap()->empty_string();
1199 Object* code = __RT_impl_Runtime_StringCharCodeAtRT(args, isolate); 1193 Object* code = __RT_impl_Runtime_StringCharCodeAtRT(args, isolate);
1200 if (code->IsNaN()) return isolate->heap()->empty_string(); 1194 if (code->IsNaN()) return isolate->heap()->empty_string();
1201 return __RT_impl_Runtime_CharFromCode(Arguments(1, &code), isolate); 1195 return __RT_impl_Runtime_StringCharFromCode(Arguments(1, &code), isolate);
1202 } 1196 }
1203 1197
1204 1198
1205 RUNTIME_FUNCTION(Runtime_OneByteSeqStringGetChar) { 1199 RUNTIME_FUNCTION(Runtime_OneByteSeqStringGetChar) {
1206 SealHandleScope shs(isolate); 1200 SealHandleScope shs(isolate);
1207 DCHECK(args.length() == 2); 1201 DCHECK(args.length() == 2);
1208 CONVERT_ARG_CHECKED(SeqOneByteString, string, 0); 1202 CONVERT_ARG_CHECKED(SeqOneByteString, string, 0);
1209 CONVERT_INT32_ARG_CHECKED(index, 1); 1203 CONVERT_INT32_ARG_CHECKED(index, 1);
1210 return Smi::FromInt(string->SeqOneByteStringGet(index)); 1204 return Smi::FromInt(string->SeqOneByteStringGet(index));
1211 } 1205 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 1247
1254 1248
1255 RUNTIME_FUNCTION(Runtime_StringGetLength) { 1249 RUNTIME_FUNCTION(Runtime_StringGetLength) {
1256 HandleScope scope(isolate); 1250 HandleScope scope(isolate);
1257 DCHECK(args.length() == 1); 1251 DCHECK(args.length() == 1);
1258 CONVERT_ARG_HANDLE_CHECKED(String, s, 0); 1252 CONVERT_ARG_HANDLE_CHECKED(String, s, 0);
1259 return Smi::FromInt(s->length()); 1253 return Smi::FromInt(s->length());
1260 } 1254 }
1261 } // namespace internal 1255 } // namespace internal
1262 } // namespace v8 1256 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698