Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1417503006: Revert of Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purpos… (Closed)

Created:
5 years, 1 month ago by dcaiafa
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org, dstockwell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purpos… (patchset #2 id:20001 of https://codereview.chromium.org/1420033003/ ) Reason for revert: Revert due to: content_browsertests failure: BackgroundTracingManagerBrowserTest.SetActiveScenarioFailsWithInvalidPreemptiveConfig content_unittests failures: BackgroundTracingConfigTest.PreemptiveConfigFromInvalidString BackgroundTracingConfigTest.ReactiveConfigFromInvalidString Build link: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/48840 Original issue's description: > Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purposes. > > Also added a scenario name to the config, for easier filtering on the backend. > > R=dsinclair,shatch > BUG=546193 > > Committed: https://crrev.com/1607e4b8ae91d4c9ab09c54405c468e989b96e9b > Cr-Commit-Position: refs/heads/master@{#356101} TBR=dsinclair@chromium.org,simonhatch@chromium.org,fmeawad@chromium.org,oysteine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546193 Committed: https://crrev.com/23da63b66d8fb03f521e136b4f4ea9b13945d34c Cr-Commit-Position: refs/heads/master@{#356132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -192 lines) Patch
M content/browser/tracing/background_tracing_config_impl.h View 3 chunks +0 lines, -14 lines 0 comments Download
M content/browser/tracing/background_tracing_config_impl.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 2 chunks +0 lines, -34 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_browsertest.cc View 2 chunks +0 lines, -90 lines 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 4 chunks +5 lines, -38 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dcaiafa
5 years, 1 month ago (2015-10-26 21:45:11 UTC) #1
Created Revert of Background tracing: Tracing scenarios can now enable/disable
Blink features, for A/B testing purpos…

Powered by Google App Engine
This is Rietveld 408576698