Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Unified Diff: content/browser/tracing/background_tracing_config_impl.cc

Issue 1417503006: Revert of Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purpos… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/background_tracing_config_impl.cc
diff --git a/content/browser/tracing/background_tracing_config_impl.cc b/content/browser/tracing/background_tracing_config_impl.cc
index 720656a24dab4517850e176f971d8b3fdb990c08..cc944ce90ef6a624284c8c43f8fbf29d0f9d2a2f 100644
--- a/content/browser/tracing/background_tracing_config_impl.cc
+++ b/content/browser/tracing/background_tracing_config_impl.cc
@@ -16,10 +16,6 @@
const char kConfigModeKey[] = "mode";
const char kConfigModePreemptive[] = "PREEMPTIVE_TRACING_MODE";
const char kConfigModeReactive[] = "REACTIVE_TRACING_MODE";
-
-const char kConfigScenarioName[] = "scenario_name";
-const char kConfigEnableBlinkFeatures[] = "enable_blink_features";
-const char kConfigDisableBlinkFeatures[] = "disable_blink_features";
const char kConfigCategoryKey[] = "category";
const char kConfigCategoryBenchmark[] = "BENCHMARK";
@@ -107,13 +103,6 @@
}
dict->Set(kConfigsKey, configs_list.Pass());
-
- if (!scenario_name_.empty())
- dict->SetString(kConfigScenarioName, scenario_name_);
- if (!enable_blink_features_.empty())
- dict->SetString(kConfigEnableBlinkFeatures, enable_blink_features_);
- if (!disable_blink_features_.empty())
- dict->SetString(kConfigDisableBlinkFeatures, disable_blink_features_);
}
void BackgroundTracingConfigImpl::AddPreemptiveRule(
@@ -151,11 +140,6 @@
return nullptr;
}
- dict->GetString(kConfigScenarioName, &config->scenario_name_);
- dict->GetString(kConfigEnableBlinkFeatures, &config->enable_blink_features_);
- dict->GetString(kConfigDisableBlinkFeatures,
- &config->disable_blink_features_);
-
return config.Pass();
}

Powered by Google App Engine
This is Rietveld 408576698