Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Unified Diff: content/browser/tracing/background_tracing_config_unittest.cc

Issue 1417503006: Revert of Background tracing: Tracing scenarios can now enable/disable Blink features, for A/B testing purpos… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/background_tracing_config_unittest.cc
diff --git a/content/browser/tracing/background_tracing_config_unittest.cc b/content/browser/tracing/background_tracing_config_unittest.cc
index a6a5ebfc25e3af441e5542ff95483b7e5a38f372..34c206be9d76db338ec7210b826048a7080e530e 100644
--- a/content/browser/tracing/background_tracing_config_unittest.cc
+++ b/content/browser/tracing/background_tracing_config_unittest.cc
@@ -256,17 +256,6 @@
EXPECT_EQ(RuleToString(config->rules()[1]),
"{\"rule\":\"MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED\","
"\"trigger_name\":\"foo2\"}");
-
- config = ReadFromJSONString(
- "{\"category\":\"BENCHMARK_DEEP\",\"configs\":[{\"rule\":"
- "\"MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED\",\"trigger_name\":"
- "\"foo1\"}],\"disable_blink_features\":\"SlowerWeb1,SlowerWeb2\","
- "\"enable_blink_features\":\"FasterWeb1,FasterWeb2\","
- "\"mode\":\"PREEMPTIVE_TRACING_MODE\","
- "\"scenario_name\":\"my_awesome_experiment\"}");
- EXPECT_EQ(config->enable_blink_features(), "FasterWeb1,FasterWeb2");
- EXPECT_EQ(config->disable_blink_features(), "SlowerWeb1,SlowerWeb2");
- EXPECT_EQ(config->scenario_name(), "my_awesome_experiment");
}
TEST_F(BackgroundTracingConfigTest, ReactiveConfigFromValidString) {
@@ -417,29 +406,6 @@
"SPECIFIC_HISTOGRAM_AND_VALUE\",\"trigger_delay\":10}],\"mode\":"
"\"PREEMPTIVE_TRACING_MODE\"}");
}
-
- {
- config.reset(
- new BackgroundTracingConfigImpl(BackgroundTracingConfig::PREEMPTIVE));
- config->set_category_preset(BackgroundTracingConfigImpl::BENCHMARK_DEEP);
-
- scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
- dict->SetString("rule", "MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED");
- dict->SetString("trigger_name", "foo1");
- config->AddPreemptiveRule(dict.get());
-
- config->scenario_name_ = "my_awesome_experiment";
- config->enable_blink_features_ = "FasterWeb1,FasterWeb2";
- config->disable_blink_features_ = "SlowerWeb1,SlowerWeb2";
-
- EXPECT_EQ(ConfigToString(config.get()),
- "{\"category\":\"BENCHMARK_DEEP\",\"configs\":[{\"rule\":"
- "\"MONITOR_AND_DUMP_WHEN_TRIGGER_NAMED\",\"trigger_name\":"
- "\"foo1\"}],\"disable_blink_features\":\"SlowerWeb1,SlowerWeb2\","
- "\"enable_blink_features\":\"FasterWeb1,FasterWeb2\","
- "\"mode\":\"PREEMPTIVE_TRACING_MODE\","
- "\"scenario_name\":\"my_awesome_experiment\"}");
- }
}
TEST_F(BackgroundTracingConfigTest, InvalidPreemptiveConfigToString) {

Powered by Google App Engine
This is Rietveld 408576698