Fix to give `LineInfo` to options error spans.

Fix to give `LineInfo` to options error spans.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/808f32d61d1188451a54feac6173054814dbbd22

[pquitslund, 2015-10-27 03:52:54]

pquitslund@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-10-27 03:54:40]

LGTM

[pquitslund, 2015-10-27 04:09:53]

Committed patchset #1 (id:1) manually as
808f32d61d1188451a54feac6173054814dbbd22 (presubmit successful).

[Brian Wilkerson, 2015-10-27 13:18:29]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-10-27 13:18:29]

https://codereview.chromium.org/1417363007/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
(right):

https://codereview.chromium.org/1417363007/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/analysis_options_test.dart:1: //
Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
2014 --> 2015

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:105: if (content.codeUnitAt(index) ==
0x0A) {
For Dart files we accept either CR, CR/LF, or LF as an end of line marker. I
think we need to do the same thing here.

[pquitslund, 2015-10-27 15:31:44]

Thanks Brian!

Question inline and then a follow-up CL.

https://codereview.chromium.org/1417363007/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
(right):

https://codereview.chromium.org/1417363007/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/analysis/analysis_options_test.dart:1: //
Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
On 2015/10/27 13:18:29, Brian Wilkerson wrote:
> 2014 --> 2015

Done.

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:105: if (content.codeUnitAt(index) ==
0x0A) {
On 2015/10/27 13:18:29, Brian Wilkerson wrote:
> For Dart files we accept either CR, CR/LF, or LF as an end of line marker. I
> think we need to do the same thing here.

I was folllowing HTML's suit but this is not a bad idea.

I'm probably being thick but could you point me to where line info is computed
for Dart files?

[Brian Wilkerson, 2015-10-27 15:59:44]

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
File pkg/analyzer/lib/src/task/options.dart (right):

https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
pkg/analyzer/lib/src/task/options.dart:105: if (content.codeUnitAt(index) ==
0x0A) {
We compute line info while scanning, as part of the Scanner.

[pquitslund, 2015-10-27 16:07:33]

On 2015/10/27 15:59:44, Brian Wilkerson wrote:
>
https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
> File pkg/analyzer/lib/src/task/options.dart (right):
> 
>
https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
> pkg/analyzer/lib/src/task/options.dart:105: if (content.codeUnitAt(index) ==
> 0x0A) {
> We compute line info while scanning, as part of the Scanner.

Ah, thanks!

[pquitslund, 2015-10-27 16:36:20]

On 2015/10/27 16:07:33, pquitslund wrote:
> On 2015/10/27 15:59:44, Brian Wilkerson wrote:
> >
>
https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
> > File pkg/analyzer/lib/src/task/options.dart (right):
> > 
> >
>
https://codereview.chromium.org/1417363007/diff/1/pkg/analyzer/lib/src/task/o...
> > pkg/analyzer/lib/src/task/options.dart:105: if (content.codeUnitAt(index) ==
> > 0x0A) {
> > We compute line info while scanning, as part of the Scanner.
> 
> Ah, thanks!

https://codereview.chromium.org/1413783005/