Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: pkg/analysis_server/test/integration/analysis/analysis_options_test.dart

Issue 1417363007: Fix to give `LineInfo` to options error spans. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart b/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..c1cabe0aea9ba49e4b237763e277763a21e9f4a9
--- /dev/null
+++ b/pkg/analysis_server/test/integration/analysis/analysis_options_test.dart
@@ -0,0 +1,47 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
Brian Wilkerson 2015/10/27 13:18:29 2014 --> 2015
pquitslund 2015/10/27 15:31:44 Done.
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library test.integration.analysis.analysis_options;
+
+import 'package:analysis_server/plugin/protocol/protocol.dart';
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+import 'package:unittest/unittest.dart';
+
+import '../../utils.dart';
+import '../integration_tests.dart';
+
+main() {
+ initializeTestEnvironment();
+ defineReflectiveTests(OptionsIntegrationTest);
+}
+
+@reflectiveTest
+class OptionsIntegrationTest extends AbstractAnalysisServerIntegrationTest {
+ test_option_warning() async {
+ String options = sourcePath('.analysis_options');
+ writeFile(
+ options,
+ '''
+linter:
+ rules:
+ - camel_case_typo # :)
+''');
+
+ standardAnalysisSetup();
+
+ await analysisFinished;
+
+ expect(currentAnalysisErrors[options], isList);
+ List<AnalysisError> errors = currentAnalysisErrors[options];
+ expect(errors, hasLength(1));
+ AnalysisError error = errors[0];
+ expect(error.location.file, options);
+ expect(error.severity, AnalysisErrorSeverity.WARNING);
+ expect(error.type, AnalysisErrorType.STATIC_WARNING);
+ expect(error.location.offset, 23);
+ expect(error.location.length, 'camel_case_typo'.length);
+ expect(error.location.startLine, 3);
+ expect(error.location.startColumn, 7);
+ }
+}
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/analysis/test_all.dart » ('j') | pkg/analyzer/lib/src/task/options.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698