Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: pkg/analysis_server/test/integration/analysis/analysis_options_test.dart

Issue 1417363007: Fix to give `LineInfo` to options error spans. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
Brian Wilkerson 2015/10/27 13:18:29 2014 --> 2015
pquitslund 2015/10/27 15:31:44 Done.
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 library test.integration.analysis.analysis_options;
6
7 import 'package:analysis_server/plugin/protocol/protocol.dart';
8 import 'package:test_reflective_loader/test_reflective_loader.dart';
9 import 'package:unittest/unittest.dart';
10
11 import '../../utils.dart';
12 import '../integration_tests.dart';
13
14 main() {
15 initializeTestEnvironment();
16 defineReflectiveTests(OptionsIntegrationTest);
17 }
18
19 @reflectiveTest
20 class OptionsIntegrationTest extends AbstractAnalysisServerIntegrationTest {
21 test_option_warning() async {
22 String options = sourcePath('.analysis_options');
23 writeFile(
24 options,
25 '''
26 linter:
27 rules:
28 - camel_case_typo # :)
29 ''');
30
31 standardAnalysisSetup();
32
33 await analysisFinished;
34
35 expect(currentAnalysisErrors[options], isList);
36 List<AnalysisError> errors = currentAnalysisErrors[options];
37 expect(errors, hasLength(1));
38 AnalysisError error = errors[0];
39 expect(error.location.file, options);
40 expect(error.severity, AnalysisErrorSeverity.WARNING);
41 expect(error.type, AnalysisErrorType.STATIC_WARNING);
42 expect(error.location.offset, 23);
43 expect(error.location.length, 'camel_case_typo'.length);
44 expect(error.location.startLine, 3);
45 expect(error.location.startColumn, 7);
46 }
47 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/test/integration/analysis/test_all.dart » ('j') | pkg/analyzer/lib/src/task/options.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698