Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1417363002: Revert of Use FrameSelection::selectedText where possible. (Closed)

Created:
5 years, 2 months ago by tkent
Modified:
5 years, 2 months ago
Reviewers:
kotenkov, yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use FrameSelection::selectedText where possible. (patchset #6 id:100001 of https://codereview.chromium.org/1377963004/ ) Reason for revert: Regressed speedometer significantly. crbug.com/546248 Original issue's description: > Use FrameSelection::selectedText where possible. > > Substitute occurrences of selection -> range -> (text or html) conversions with > direct selection -> (text or html) conversions using existing functions. > > BUG= > > Committed: https://crrev.com/9c2436064ebdcb9192dfacac96944f2753a2ce78 > Cr-Commit-Position: refs/heads/master@{#355247} TBR=yosin@chromium.org,kotenkov@yandex-team.ru NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546248 Committed: https://crrev.com/8ac1269525fdc94fc222e24ccfdfd8b93a9c7cc5 Cr-Commit-Position: refs/heads/master@{#355661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransfer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/serializers/Serialization.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
tkent
Created Revert of Use FrameSelection::selectedText where possible.
5 years, 2 months ago (2015-10-22 22:45:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417363002/1
5 years, 2 months ago (2015-10-22 22:45:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 22:47:34 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 22:48:35 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ac1269525fdc94fc222e24ccfdfd8b93a9c7cc5
Cr-Commit-Position: refs/heads/master@{#355661}

Powered by Google App Engine
This is Rietveld 408576698