third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp - Issue 1417363002: Revert of Use FrameSelection::selectedText where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

Issue 1417363002: Revert of Use FrameSelection::selectedText where possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp ('k') | third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

index 3384b7b6c5d5b56b44e07e2d8cd59a782759e004..b3421b15e87f3c948e148727b9f18a554e1b5353 100644

--- a/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp

@@ -189,7 +189,6 @@

void HTMLTextFormControlElement::select(NeedToDispatchSelectEvent eventBehaviour)

{

- // We have to update layout here to use isFocusable().

document().updateLayoutIgnorePendingStylesheets();

setSelectionRange(0, std::numeric_limits<int>::max(), SelectionHasNoDirection, eventBehaviour, isFocusable() ? ChangeSelectionAndFocus : NotChangeSelection);

}

@@ -354,10 +353,6 @@

{

if (openShadowRoot() || !isTextFormControl() || !inDocument())

return;

- // We need to update layout here so that we have proper types for both dom tree and composed tree selection.

- // See https://codereview.chromium.org/1377963004/

- document().updateLayoutIgnorePendingStylesheets();

const int editorValueLength = static_cast<int>(innerEditorValue().length());

ASSERT(editorValueLength >= 0);