Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1417213006: Switch all LayoutTests to use new AX name calculation (Closed)

Created:
5 years, 1 month ago by dmazzoni
Modified:
5 years, 1 month ago
Reviewers:
aboxhall, pfeldman
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, caseq+blink_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, yuzo+watch_chromium.org, lushnikov+blink_chromium.org, darktears, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, plundblad+watch_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch all LayoutTests to use new AX name calculation BUG=473220, 550663 Committed: https://crrev.com/3f6ec08f8035d976cf5fe8a338de3202f42fd152 Cr-Commit-Position: refs/heads/master@{#358900}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Address feedback #

Patch Set 3 : refactor stringValueOfControl #

Total comments: 7

Patch Set 4 : Fix some broken test expectations #

Patch Set 5 : Removed platform-specific expectations for one test #

Patch Set 6 : Fix accessibility/canvas-fallback-content-labels.html expectations #

Patch Set 7 : Update an oilpan expectation too #

Patch Set 8 : Fix canvas-fallback-content-labels-expected.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+623 lines, -907 lines) Patch
M components/test_runner/web_ax_object_proxy.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/test_runner/web_ax_object_proxy.cc View 6 chunks +3 lines, -54 lines 0 comments Download
M content/test/data/accessibility/html/area-expected-mac.txt View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/html/area-expected-win.txt View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/OilpanExpectations View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/animation-policy.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/animation-policy-expected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-describedby-on-input.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-describedby-on-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/aria-help.html View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/aria-help-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-hidden.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-hidden-children-not-in-text-from-content.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-hidden-children-not-in-text-from-content-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-hidden-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-label.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-on-input.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-on-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-label.html View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-label-expected.txt View 1 chunk +4 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby.html View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html View 1 2 3 2 chunks +10 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label-expected.txt View 1 2 3 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-labelledby-stay-within.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-option-role.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-option-role-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-owns.html View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-tab-roles.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-tab-roles-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-toggle-button-with-title.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/aria-toggle-button-with-title-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/br-element-has-correct-title.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/br-element-has-correct-title-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/button-title-uses-inner-img-alt.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/button-title-uses-inner-img-alt-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/calling-accessibility-methods-with-pending-layout-causes-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-2-expected.txt View 21 chunks +21 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-labels.html View 1 2 3 4 5 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/canvas-fallback-content-labels-expected.txt View 1 2 3 4 5 6 7 2 chunks +22 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/computed-text-with-height-0.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/display-none-change.html View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/dl-role.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/focusable-div.html View 1 2 3 2 chunks +9 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/focusable-div-expected.txt View 1 2 3 1 chunk +8 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/heading-level.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-link-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-map-title-causes-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-map1.html View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-map1-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-map2.html View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/image-map2-expected.txt View 1 chunk +3 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-alt-tag-only-whitespace.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-alt-tag-only-whitespace-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-aria-button-alt-tag.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-aria-button-alt-tag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-fallsback-to-title.html View 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/img-fallsback-to-title-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/input-file-causes-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/input-image-alt.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/input-image-alt-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/legend.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/link-inside-button-accessible-text.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/link-inside-button-accessible-text-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/loading-iframe-sends-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/meter-value.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/non-data-table-cell-title-ui-element.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/radio-button-title-label.html View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/radio-button-title-label-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/role-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/secure-textfield-title-ui.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/spinbutton-value.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/spinbutton-value-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/svg-bounds.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/svg-bounds-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/svg-image.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/svg-image-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-cell-spans-expected.txt View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-cells-expected.txt View 1 chunk +5 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-detection-expected.txt View 4 chunks +19 lines, -38 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-one-cell-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-with-aria-role-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/table-with-rules-expected.txt View 1 chunk +5 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/th-as-title-ui.html View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/LayoutTests/accessibility/th-as-title-ui-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/title-ui-element-correctness.html View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/title-ui-element-correctness-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/accessibility/whitespace-in-name-calc.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/date-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/date-picker-ax-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/month-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/month-picker-ax-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/week-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/calendar-picker/week-picker-ax-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html View 2 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes-expected.txt View 1 chunk +16 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/resources/multiple-fields-ax-aria-attributes.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/accessibility/canvas-fallback-content-labels-expected.txt View 1 2 3 4 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/accessibility/canvas-fallback-content-labels-expected.txt View 1 2 3 4 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h View 2 chunks +7 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp View 6 chunks +27 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.h View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 2 11 chunks +84 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObject.cpp View 1 2 3 4 5 4 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 4 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
dmazzoni
Suggestion: review the cpp/h files first, then we can work through all of the changes ...
5 years, 1 month ago (2015-11-05 17:15:44 UTC) #2
aboxhall
Just commenting on cpp/h. Only one major issue. https://codereview.chromium.org/1417213006/diff/1/components/test_runner/web_ax_object_proxy.cc File components/test_runner/web_ax_object_proxy.cc (left): https://codereview.chromium.org/1417213006/diff/1/components/test_runner/web_ax_object_proxy.cc#oldcode317 components/test_runner/web_ax_object_proxy.cc:317: // ...
5 years, 1 month ago (2015-11-05 17:49:21 UTC) #3
dmazzoni
https://codereview.chromium.org/1417213006/diff/1/components/test_runner/web_ax_object_proxy.cc File components/test_runner/web_ax_object_proxy.cc (left): https://codereview.chromium.org/1417213006/diff/1/components/test_runner/web_ax_object_proxy.cc#oldcode317 components/test_runner/web_ax_object_proxy.cc:317: // FIXME: Concatenate all attributes of the AXObject. On ...
5 years, 1 month ago (2015-11-06 00:21:18 UTC) #5
aboxhall
Missing upload? :( https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp#newcode1945 third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1945: return stringValue(); On 2015/11/06 00:21:17, dmazzoni ...
5 years, 1 month ago (2015-11-06 01:11:22 UTC) #6
aboxhall
Missing upload? :( https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp#newcode1945 third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1945: return stringValue(); On 2015/11/06 00:21:17, dmazzoni ...
5 years, 1 month ago (2015-11-06 01:11:23 UTC) #7
dmazzoni
On 2015/11/06 01:11:23, aboxhall wrote: > Missing upload? :( Sorry! Shuttle wifi wasn't able to ...
5 years, 1 month ago (2015-11-06 04:27:52 UTC) #8
dmazzoni
https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp File third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp (right): https://codereview.chromium.org/1417213006/diff/1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp#newcode1945 third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp:1945: return stringValue(); On 2015/11/06 01:11:23, aboxhall wrote: > On ...
5 years, 1 month ago (2015-11-06 04:54:06 UTC) #9
aboxhall
lgtm LGTM with minor issues https://codereview.chromium.org/1417213006/diff/40001/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html File third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html (right): https://codereview.chromium.org/1417213006/diff/40001/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html#newcode29 third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html:29: shouldBe("firstNameElement.role", "'AXRole: AXUnknown'"); Not ...
5 years, 1 month ago (2015-11-06 19:24:11 UTC) #10
dmazzoni
+pfeldman for trivial change to Source/devtools/ https://codereview.chromium.org/1417213006/diff/40001/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html File third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html (right): https://codereview.chromium.org/1417213006/diff/40001/third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html#newcode29 third_party/WebKit/LayoutTests/accessibility/aria-labelledby-overrides-label.html:29: shouldBe("firstNameElement.role", "'AXRole: AXUnknown'"); ...
5 years, 1 month ago (2015-11-06 22:32:26 UTC) #12
pfeldman
protocol.json lgtm
5 years, 1 month ago (2015-11-09 19:52:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213006/80001
5 years, 1 month ago (2015-11-09 19:56:33 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/1670)
5 years, 1 month ago (2015-11-09 21:55:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213006/120001
5 years, 1 month ago (2015-11-10 00:40:40 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/138229)
5 years, 1 month ago (2015-11-10 02:30:43 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1417213006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1417213006/140001
5 years, 1 month ago (2015-11-10 17:53:27 UTC) #26
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 1 month ago (2015-11-10 21:06:56 UTC) #27
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:07:52 UTC) #28
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/3f6ec08f8035d976cf5fe8a338de3202f42fd152
Cr-Commit-Position: refs/heads/master@{#358900}

Powered by Google App Engine
This is Rietveld 408576698