third_party/WebKit/Source/modules/accessibility/AXNodeObject.h - Issue 1417213006: Switch all LayoutTests to use new AX name calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

Issue 1417213006: Switch all LayoutTests to use new AX name calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix canvas-fallback-content-labels-expected.txt Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

index 576ab6210f23b6fc2a2361094ee482ca7c2601dc..0061dbb9691a51c73aff7dd0a900953475360bf0 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h

@@ -108,7 +108,7 @@ protected:

bool isImage() const final;

bool isImageButton() const;

bool isInputImage() const final;

- bool isLink() const final;

+ bool isLink() const override;

bool isMenu() const final;

bool isMenuButton() const final;

bool isMeter() const final;

@@ -190,7 +190,7 @@ protected:

void insertChild(AXObject*, unsigned index);

// DOM and Render tree access.

- Element* actionElement() const final;

+ Element* actionElement() const override;

Element* anchorElement() const override;

Document* document() const override;

Node* node() const override { return m_node; }

@@ -228,6 +228,7 @@ private:

float stepValueForRange() const;

AXObject* findChildWithTagName(const HTMLQualifiedName&) const;

bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;

+ String stringValueOfControl() const;

};

DEFINE_AX_OBJECT_TYPE_CASTS(AXNodeObject, isAXNodeObject());