third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp - Issue 1417213006: Switch all LayoutTests to use new AX name calculation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

Issue 1417213006: Switch all LayoutTests to use new AX name calculation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix canvas-fallback-content-labels-expected.txt Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

index fb97ce9e211147ee829790797a7f21a7a1a89aa7..655ecc97c19445a27cece1fe2d03245fc8fe279a 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp

@@ -2474,10 +2474,9 @@ void AXLayoutObject::addImageMapChildren()

for (HTMLAreaElement& area : Traversal<HTMLAreaElement>::descendantsOf(*map)) {

// add an <area> element for this child if it has a link

- if (area.isLink()) {

- AXImageMapLink* areaObject = toAXImageMapLink(axObjectCache().getOrCreate(ImageMapLinkRole));

- areaObject->setHTMLAreaElement(&area);

- areaObject->setHTMLMapElement(map);

+ AXObject* obj = axObjectCache().getOrCreate(&area);

+ if (obj) {

+ AXImageMapLink* areaObject = toAXImageMapLink(obj);

areaObject->setParent(this);

ASSERT(areaObject->axObjectID() != 0);

if (!areaObject->accessibilityIsIgnored())