Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417033004: Merge to XFA: Add type cast definitions for CPDF_Name. (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add type cast definitions for CPDF_Name. This Cl adds ToName, CPDF_Object::AsName and CPDF_Object::IsName and updates the src to use them as needed. BUG=pdfium:201 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1417823005 . (cherry picked from commit 1c77edb7b34e03787605b7965784cea38ef9f1d7) Committed: https://pdfium.googlesource.com/pdfium/+/710c909117da4297e5a9508bedb306fc5c49eb36

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -110 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 4 chunks +12 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 2 chunks +13 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 2 chunks +11 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 9 chunks +15 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 8 chunks +19 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_action.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_bookmark.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_Utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +2 lines, -3 lines 2 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
PTAL. Merge conflict marked. https://codereview.chromium.org/1417033004/diff/1/fpdfsdk/src/fpdfppo.cpp File fpdfsdk/src/fpdfppo.cpp (right): https://codereview.chromium.org/1417033004/diff/1/fpdfsdk/src/fpdfppo.cpp#newcode190 fpdfsdk/src/fpdfppo.cpp:190: return nullptr; Merge conflict. I'm ...
5 years, 2 months ago (2015-10-21 18:00:14 UTC) #1
Tom Sepez
lgtm https://codereview.chromium.org/1417033004/diff/1/fpdfsdk/src/fpdfppo.cpp File fpdfsdk/src/fpdfppo.cpp (right): https://codereview.chromium.org/1417033004/diff/1/fpdfsdk/src/fpdfppo.cpp#newcode190 fpdfsdk/src/fpdfppo.cpp:190: return nullptr; On 2015/10/21 18:00:14, dsinclair wrote: > ...
5 years, 2 months ago (2015-10-21 19:41:04 UTC) #2
dsinclair
5 years, 2 months ago (2015-10-21 19:46:16 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
710c909117da4297e5a9508bedb306fc5c49eb36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698