core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp - Issue 1417033004: Merge to XFA: Add type cast definitions for CPDF_Name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

Issue 1417033004: Merge to XFA: Add type cast definitions for CPDF_Name. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

index b1e89e8cc471b631488b7834bcb9a65d3e9a977a..f051d0db5a1c394a159b26f23a9105cff9eba446 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp

@@ -88,7 +88,7 @@ void CPDF_StreamContentParser::Handle_BeginImage() {

CPDF_Object* pCSObj = NULL;

if (pDict->KeyExist(FX_BSTRC("ColorSpace"))) {

pCSObj = pDict->GetElementValue(FX_BSTRC("ColorSpace"));

- if (pCSObj->GetType() == PDFOBJ_NAME) {

+ if (pCSObj->IsName()) {

CFX_ByteString name = pCSObj->GetString();

if (name != FX_BSTRC("DeviceRGB") && name != FX_BSTRC("DeviceGray") &&

name != FX_BSTRC("DeviceCMYK")) {