Remove some implicit Point to PointF conversions, add helpers.

Remove some implicit Point to PointF conversions, add helpers.

This adds gfx::ScaleTo{Floored,Ceiled,Rounded}Point() helpers
similar to those that exist for Rect and Size. It uses those
helpers to scale integer points to integer points, and avoid
implicit conversions to PointFs in the calling code.

Also removes some implicit conversions to PointF with
ui::SelectionBounds.

R=sadrul, sky
BUG=342848
Committed: https://crrev.com/34a8990806a42ee9356ce5b2f932057169c03a90
Cr-Commit-Position: refs/heads/master@{#355451}

[danakj, 2015-10-20 21:03:16]

This hits implicit point->pointf for selection bounds code and some scaling
code. Should be simple, I'll try give fast/small CLs like this as possible.

[danakj, 2015-10-20 21:45:49]

danakj@chromium.org changed reviewers:
- sadrul@chromium.org

[danakj, 2015-10-20 21:45:50]

The last file was using ScaleToFlooredPoint type helpers, so I rolled most of
those type of change in here and added the helper methods to point.h. These
still are not changes related to events so should be simple.

[danakj, 2015-10-20 21:48:09]

Description was changed from

==========
views: Remove some implicit Point to PointF conversions.

R=sadrul, sky
BUG=342848
==========

to

==========
Remove some implicit Point to PointF conversions, add helpers.

This adds gfx::ScaleTo{Floored,Ceiled,Rounded}Point() helpers
similar to those that exist for Rect and Size. It uses those
helpers to scale integer points to integer points, and avoid
implicit conversions to PointFs in the calling code.

Also removes some implicit conversions to PointF with
ui::SelectionBounds.

R=sadrul, sky
BUG=342848
==========

[sky, 2015-10-21 16:45:00]

https://codereview.chromium.org/1417023002/diff/100001/ui/gfx/geometry/point.cc
File ui/gfx/geometry/point.cc (right):

https://codereview.chromium.org/1417023002/diff/100001/ui/gfx/geometry/point....
ui/gfx/geometry/point.cc:73: Point ScaleToCeiledPoint(const Point& point, float
scale) {
WDYT of inlining the single float variants? For example, in the header having
this as :
return ScaleToCeieldPoint(point, scale, scale);
?

[danakj, 2015-10-21 17:55:41]

https://codereview.chromium.org/1417023002/diff/100001/ui/gfx/geometry/point.cc
File ui/gfx/geometry/point.cc (right):

https://codereview.chromium.org/1417023002/diff/100001/ui/gfx/geometry/point....
ui/gfx/geometry/point.cc:73: Point ScaleToCeiledPoint(const Point& point, float
scale) {
On 2015/10/21 16:45:00, sky wrote:
> WDYT of inlining the single float variants? For example, in the header having
> this as :
> return ScaleToCeieldPoint(point, scale, scale);
> ?

I would but they require the PointF definition then, and the point_f.h header
already includes the point.h header for the explicit constructor. So you'd get
circular includes. I could put them in another file.. or something. wdyt?
size.h/cc did it this way. rect.h did it inline cuz it didn't convert to a
RectF.

[sky, 2015-10-21 21:58:28]

Ugh, ok. Go with what you have. LGTM

[danakj, 2015-10-21 23:11:48]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-10-21 23:12:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1417023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1417023002/100001

[commit-bot: I haz the power, 2015-10-22 00:25:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-22 00:25:53]

Patchset 6 (id:??) landed as
https://crrev.com/34a8990806a42ee9356ce5b2f932057169c03a90
Cr-Commit-Position: refs/heads/master@{#355451}