Remove some implicit Point to PointF conversions, add helpers.

ui/views/touchui/touch_selection_controller_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/aura/client/screen_position_client.h"
 #include "ui/aura/test/test_cursor_client.h"
 #include "ui/aura/window.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 590 matching lines @@
  public:
   explicit TestTouchEditable(aura::Window* window)
       : window_(window) {
     DCHECK(window);
   }
 
   void set_bounds(const gfx::Rect& bounds) {
     bounds_ = bounds;
   }
 
-  void set_cursor_rect(const gfx::Rect& cursor_rect) {
+  void set_cursor_rect(const gfx::RectF& cursor_rect) {
     cursor_bound_.SetEdge(cursor_rect.origin(), cursor_rect.bottom_left());
     cursor_bound_.set_type(ui::SelectionBound::Type::CENTER);
   }
 
   ~TestTouchEditable() override {}
 
  private:
   // Overridden from ui::TouchEditable.
   void SelectRect(const gfx::Point& start, const gfx::Point& end) override {
     NOTREACHED();
@@ skipping 58 matching lines @@
   CreateWidget();
 
   TestTouchEditable touch_editable(widget_->GetNativeView());
   scoped_ptr<ui::TouchEditingControllerDeprecated> touch_selection_controller(
       ui::TouchEditingControllerDeprecated::Create(&touch_editable));
 
   touch_editable.set_bounds(gfx::Rect(0, 0, 100, 20));
 
   // Put the cursor completely inside the client bounds. Handle should be
   // visible.
-  touch_editable.set_cursor_rect(gfx::Rect(2, 0, 1, 20));
+  touch_editable.set_cursor_rect(gfx::RectF(2.f, 0.f, 1.f, 20.f));
   touch_selection_controller->SelectionChanged();
   EXPECT_TRUE(IsCursorHandleVisibleFor(touch_selection_controller.get()));
 
   // Move the cursor up such that |kBarMinHeight| pixels are still in the client
   // bounds. Handle should still be visible.
-  touch_editable.set_cursor_rect(gfx::Rect(2, kBarMinHeight - 20, 1, 20));
+  touch_editable.set_cursor_rect(
+      gfx::RectF(2.f, kBarMinHeight - 20.f, 1.f, 20.f));
   touch_selection_controller->SelectionChanged();
   EXPECT_TRUE(IsCursorHandleVisibleFor(touch_selection_controller.get()));
 
   // Move the cursor up such that less than |kBarMinHeight| pixels are in the
   // client bounds. Handle should be hidden.
-  touch_editable.set_cursor_rect(gfx::Rect(2, kBarMinHeight - 20 - 1, 1, 20));
+  touch_editable.set_cursor_rect(
+      gfx::RectF(2.f, kBarMinHeight - 20.f - 1.f, 1.f, 20.f));
   touch_selection_controller->SelectionChanged();
   EXPECT_FALSE(IsCursorHandleVisibleFor(touch_selection_controller.get()));
 
   // Move the Cursor down such that |kBarBottomAllowance| pixels are out of the
   // client bounds. Handle should be visible.
-  touch_editable.set_cursor_rect(gfx::Rect(2, kBarBottomAllowance, 1, 20));
+  touch_editable.set_cursor_rect(
+      gfx::RectF(2.f, kBarBottomAllowance, 1.f, 20.f));
   touch_selection_controller->SelectionChanged();
   EXPECT_TRUE(IsCursorHandleVisibleFor(touch_selection_controller.get()));
 
   // Move the cursor down such that more than |kBarBottomAllowance| pixels are
   // out of the client bounds. Handle should be hidden.
-  touch_editable.set_cursor_rect(gfx::Rect(2, kBarBottomAllowance + 1, 1, 20));
+  touch_editable.set_cursor_rect(
+      gfx::RectF(2.f, kBarBottomAllowance + 1.f, 1.f, 20.f));
   touch_selection_controller->SelectionChanged();
   EXPECT_FALSE(IsCursorHandleVisibleFor(touch_selection_controller.get()));
 
   touch_selection_controller.reset();
 }
 
 TEST_F(TouchSelectionControllerImplTest, HandlesStackAboveParent) {
   ui::EventTarget* root = GetContext();
   ui::EventTargeter* targeter = root->GetEventTargeter();
 
   // Create the first window containing a Views::Textfield.
   CreateTextfield();
   aura::Window* window1 = textfield_widget_->GetNativeView();
 
   // Start touch editing, check that the handle is above the first window, and
   // end touch editing.
   StartTouchEditing();
-  gfx::Point test_point = GetCursorHandleDragPoint();
+  auto test_point = gfx::PointF(GetCursorHandleDragPoint());
   ui::MouseEvent test_event1(ui::ET_MOUSE_MOVED, test_point, test_point,
                              ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE);
   EXPECT_EQ(GetCursorHandleNativeView(),
             targeter->FindTargetForEvent(root, &test_event1));
   EndTouchEditing();
 
   // Create the second (empty) window over the first one.
   CreateWidget();
   aura::Window* window2 = widget_->GetNativeView();
 
@@ skipping 85 matching lines @@
   // Start touch editing; then press a key and ensure it deactivates touch
   // selection.
   StartTouchEditing();
   EXPECT_TRUE(GetSelectionController());
   generator.PressKey(ui::VKEY_A, 0);
   RunPendingMessages();
   EXPECT_FALSE(GetSelectionController());
 }
 
 }  // namespace views