Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1416753002: Add debugging helper to GrDrawTarget (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@mdb-adddeps
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add debugging helper to GrDrawTarget This CL relies on https://codereview.chromium.org/1414773002/ (Add the machinery to GrDrawTarget to enable topological sorting) BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/4beb5c117b355599e2fd26b8b3d19de99512cb69

Patch Set 1 #

Patch Set 2 : Renamed GrDrawTarget::print to dump #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/gpu/GrContext.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1414773002 Patch 40001

Messages

Total messages: 13 (6 generated)
robertphillips
5 years, 2 months ago (2015-10-19 21:52:12 UTC) #3
bsalomon
lgtm, though I think a bunch of Sk classes use "dump" for similar functionality.
5 years, 2 months ago (2015-10-20 14:01:51 UTC) #4
robertphillips
Done. Renamed 'print' to 'dump'.
5 years, 2 months ago (2015-10-20 14:17:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416753002/20001
5 years, 2 months ago (2015-10-20 14:39:02 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 14:48:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416753002/20001
5 years, 2 months ago (2015-10-20 14:49:30 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 14:50:02 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4beb5c117b355599e2fd26b8b3d19de99512cb69

Powered by Google App Engine
This is Rietveld 408576698