Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414773002: Add the machinery to GrDrawTarget to enable topological sorting (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add the machinery to GrDrawTarget to enable topological sorting This relies on https://codereview.chromium.org/1414503003/ (Add SkTTopoSort) landing first. BUG=skia:4094 Committed: https://skia.googlesource.com/skia/+/6a18665a7e831a2bd5521968825c0f990d97a4f6

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 2

Patch Set 3 : Address code review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -7 lines) Patch
M src/gpu/GrContext.cpp View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 4 chunks +66 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 3 chunks +31 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1416753002 Patch 20001

Messages

Total messages: 14 (5 generated)
robertphillips
5 years, 2 months ago (2015-10-19 18:02:36 UTC) #3
bsalomon
https://codereview.chromium.org/1414773002/diff/20001/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/1414773002/diff/20001/src/gpu/GrDrawTarget.h#newcode68 src/gpu/GrDrawTarget.h:68: void setFlag(uint32_t flag) { I'm wondering if all this ...
5 years, 2 months ago (2015-10-20 13:57:19 UTC) #4
robertphillips
PTAL https://codereview.chromium.org/1414773002/diff/20001/src/gpu/GrDrawTarget.h File src/gpu/GrDrawTarget.h (right): https://codereview.chromium.org/1414773002/diff/20001/src/gpu/GrDrawTarget.h#newcode68 src/gpu/GrDrawTarget.h:68: void setFlag(uint32_t flag) { On 2015/10/20 13:57:19, bsalomon ...
5 years, 2 months ago (2015-10-20 14:10:49 UTC) #5
bsalomon
lgtm
5 years, 2 months ago (2015-10-20 14:19:55 UTC) #6
bsalomon
lgtm lgtm
5 years, 2 months ago (2015-10-20 14:19:55 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414773002/40001
5 years, 2 months ago (2015-10-20 14:21:33 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 14:31:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414773002/40001
5 years, 2 months ago (2015-10-20 14:37:13 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 14:38:02 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6a18665a7e831a2bd5521968825c0f990d97a4f6

Powered by Google App Engine
This is Rietveld 408576698