Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184783005: Add a new gyp flag to enable resource whitelist generation. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Visibility:
Public.

Description

Add a new gyp flag to enable resource whitelist generation. BUG=338759 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255710

Patch Set 1 #

Patch Set 2 : Export the value #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M build/common.gypi View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
M build/grit_action.gypi View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
aurimas (slooooooooow)
newt: please take a look at this change. Thanks.
6 years, 9 months ago (2014-03-05 18:47:14 UTC) #1
newt (away)
lgtm
6 years, 9 months ago (2014-03-05 21:06:07 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-06 00:35:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184783005/1
6 years, 9 months ago (2014-03-06 00:38:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:20:31 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=157710
6 years, 9 months ago (2014-03-06 01:20:31 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-07 16:51:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184783005/20001
6 years, 9 months ago (2014-03-07 16:51:54 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 16:54:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 16:54:53 UTC) #10
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-07 22:28:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184783005/40001
6 years, 9 months ago (2014-03-07 22:29:24 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 22:36:35 UTC) #13
Message was sent while issue was closed. 
Change committed as 255710

Powered by Google App Engine
This is Rietveld 408576698