Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1430493005: Delete dead subset benches from nanobench (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Delete dead subset benches from nanobench This approach to subset decoding is no longer supported. We have replaced it with an implementation that does not depend on forked libraries. https://codereview.chromium.org/1406153015/ BUG=skia: Committed: https://skia.googlesource.com/skia/+/0459c9425f567b6d11ca534fb13a05de9f37b7ee

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove no longer used flags #

Patch Set 3 : Build fix: delete unused fUseCodec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -329 lines) Patch
M bench/BitmapRegionDecoderBench.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M bench/nanobench.cpp View 1 2 8 chunks +70 lines, -137 lines 0 comments Download
M bench/subset/SubsetSingleBench.h View 2 chunks +1 line, -3 lines 0 comments Download
M bench/subset/SubsetSingleBench.cpp View 3 chunks +22 lines, -36 lines 0 comments Download
M bench/subset/SubsetTranslateBench.h View 2 chunks +1 line, -3 lines 0 comments Download
M bench/subset/SubsetTranslateBench.cpp View 3 chunks +38 lines, -74 lines 0 comments Download
M bench/subset/SubsetZoomBench.h View 2 chunks +1 line, -3 lines 0 comments Download
M bench/subset/SubsetZoomBench.cpp View 3 chunks +43 lines, -70 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (8 generated)
msarett
5 years, 1 month ago (2015-11-10 16:23:11 UTC) #2
scroggo
lgtm https://codereview.chromium.org/1430493005/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (left): https://codereview.chromium.org/1430493005/diff/1/bench/nanobench.cpp#oldcode523 bench/nanobench.cpp:523: if ((useCodec || FLAGS_pngBuildTileIndex) && (path.endsWith("png") || path.endsWith("PNG"))) ...
5 years, 1 month ago (2015-11-10 22:13:17 UTC) #5
msarett
https://codereview.chromium.org/1430493005/diff/1/bench/nanobench.cpp File bench/nanobench.cpp (left): https://codereview.chromium.org/1430493005/diff/1/bench/nanobench.cpp#oldcode523 bench/nanobench.cpp:523: if ((useCodec || FLAGS_pngBuildTileIndex) && (path.endsWith("png") || path.endsWith("PNG"))) { ...
5 years, 1 month ago (2015-11-10 22:37:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430493005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430493005/20001
5 years, 1 month ago (2015-11-10 22:37:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/4158)
5 years, 1 month ago (2015-11-10 22:38:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430493005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430493005/40001
5 years, 1 month ago (2015-11-10 22:40:47 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 22:52:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0459c9425f567b6d11ca534fb13a05de9f37b7ee

Powered by Google App Engine
This is Rietveld 408576698