[Interpreter] Add support for for count operations.

[Interpreter] Add support for for count operations.

Adds support for count operations to the interpreter. Deals with count
operations on locals, globals, context allocated variables and named and
keyed properties.

Adds the following bytecodes:
  ToNumber
  Inc
  Dec

BUG=v8:4280
LOG=N
TBR=mstarzinger@chromium.org

Committed: https://crrev.com/0030805643c58dd534e772e8603857372e095de7
Cr-Commit-Position: refs/heads/master@{#31484}

[rmcilroy, 2015-10-19 17:30:21]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-19 17:30:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416623003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416623003/1

[commit-bot: I haz the power, 2015-10-19 17:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 17:31:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/10821)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9139)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[rmcilroy, 2015-10-19 17:31:26]

rmcilroy@chromium.org changed reviewers:
+ oth@chromium.org, verwaest@chromium.org

[rmcilroy, 2015-10-19 17:31:27]

Toon, Orion, PTAL, thanks.

[oth, 2015-10-20 11:18:35]

lgtm.

It'd be good to have an independent test of number cast but that'll come with
unary +/- anyway.

[Toon Verwaest, 2015-10-20 13:42:28]

lgtm

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-interpreter.cc (right):

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-interpreter.cc:2011:
Handle<Object>(Smi::FromInt(2), isolate)),
you could just write handle(Smi::FromInt(2), isolate)

[rmcilroy, 2015-10-22 12:47:56]

Rebased to include the VisitForXXX CL. Orion could you give it a last quick
once-over to check you are still happy with the changes?

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-interpreter.cc (right):

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-interpreter.cc:2011:
Handle<Object>(Smi::FromInt(2), isolate)),
On 2015/10/20 13:42:28, Toon Verwaest wrote:
> you could just write handle(Smi::FromInt(2), isolate)

Good call, done this throughout, thanks!

[rmcilroy, 2015-10-22 12:47:56]

Rebased to include the VisitForXXX CL. Orion could you give it a last quick
once-over to check you are still happy with the changes?

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-interpreter.cc (right):

https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-interpreter.cc:2011:
Handle<Object>(Smi::FromInt(2), isolate)),
On 2015/10/20 13:42:28, Toon Verwaest wrote:
> you could just write handle(Smi::FromInt(2), isolate)

Good call, done this throughout, thanks!

[oth, 2015-10-22 13:35:24]

On 2015/10/22 12:47:56, rmcilroy wrote:
> Rebased to include the VisitForXXX CL. Orion could you give it a last quick
> once-over to check you are still happy with the changes?
> 
>
https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
> File test/cctest/interpreter/test-interpreter.cc (right):
> 
>
https://codereview.chromium.org/1416623003/diff/1/test/cctest/interpreter/tes...
> test/cctest/interpreter/test-interpreter.cc:2011:
> Handle<Object>(Smi::FromInt(2), isolate)),
> On 2015/10/20 13:42:28, Toon Verwaest wrote:
> > you could just write handle(Smi::FromInt(2), isolate)
> 
> Good call, done this throughout, thanks!

Yes, still lgtm here.

[Toon Verwaest, 2015-10-22 13:55:12]

lgtm

[rmcilroy, 2015-10-22 15:06:00]

Description was changed from

==========
[Interpreter] Add support for for count operations.

Adds support for count operations to the interpreter. Deals with count
operations on locals, globals, context allocated variables and named and
keyed properties.

Adds the following bytecodes:
  ToNumber
  Inc
  Dec

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add support for for count operations.

Adds support for count operations to the interpreter. Deals with count
operations on locals, globals, context allocated variables and named and
keyed properties.

Adds the following bytecodes:
  ToNumber
  Inc
  Dec

BUG=v8:4280
LOG=N
TBR=mstarzinger@chromium.org
==========

[rmcilroy, 2015-10-22 15:06:00]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2015-10-22 15:06:25]

TBR Michi for minor compiler/bytecode-graph-builder change

[rmcilroy, 2015-10-22 15:06:28]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-10-22 15:06:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416623003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416623003/60001

[commit-bot: I haz the power, 2015-10-22 15:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 15:15:06]

Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Michael Starzinger, 2015-10-22 16:13:54]

LGTM (rubber-stamped for "compiler" directory, didn't look at the rest).

[rmcilroy, 2015-10-22 16:14:31]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-10-22 16:14:31]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
verwaest@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1416623003/#ps80001
(title: "Fix gcc error")

[commit-bot: I haz the power, 2015-10-22 16:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416623003/80001

[rmcilroy, 2015-10-22 19:21:11]

The CQ bit was unchecked by rmcilroy@chromium.org

[rmcilroy, 2015-10-22 19:21:22]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-10-22 19:21:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416623003/80001

[rmcilroy, 2015-10-22 20:34:25]

The CQ bit was unchecked by rmcilroy@chromium.org

[rmcilroy, 2015-10-22 20:38:52]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-10-22 20:38:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416623003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416623003/80001

[commit-bot: I haz the power, 2015-10-22 20:40:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-10-22 20:40:35]

Patchset 5 (id:??) landed as
https://crrev.com/0030805643c58dd534e772e8603857372e095de7
Cr-Commit-Position: refs/heads/master@{#31484}