Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420503002: [Interpreter] Add support for compound expressions. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
oth, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for compound expressions. Adds support for compound expressions for variables and named / keyed property assignments. BUG=v8:4280 LOG=N Committed: https://crrev.com/4e0d11435e99a1873c0c54e8ed170e7b5c3f9e9c Cr-Commit-Position: refs/heads/master@{#31485}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -16 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 2 2 chunks +44 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 7 chunks +171 lines, -14 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +54 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1416623003 Patch 80001

Dependent Patchsets:

Issue 1412953007 Patch 40001

Messages

Total messages: 15 (5 generated)
rmcilroy
Orion / Toon, PTAL, thanks.
5 years, 2 months ago (2015-10-20 09:42:54 UTC) #2
oth
lgtm. very cool.
5 years, 2 months ago (2015-10-20 11:22:51 UTC) #3
Toon Verwaest
lgtm
5 years, 2 months ago (2015-10-20 13:44:58 UTC) #4
rmcilroy
Also rebased. Orion - still good?
5 years, 2 months ago (2015-10-22 13:59:59 UTC) #5
oth
Yep, still lgtm here.
5 years, 2 months ago (2015-10-22 14:56:52 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420503002/40001
5 years, 2 months ago (2015-10-22 16:15:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 16:43:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420503002/40001
5 years, 2 months ago (2015-10-22 20:41:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-22 20:42:28 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 20:42:37 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/4e0d11435e99a1873c0c54e8ed170e7b5c3f9e9c
Cr-Commit-Position: refs/heads/master@{#31485}

Powered by Google App Engine
This is Rietveld 408576698