Parse {animation,transition}-timing-function in CSSPropertyParser with CSSParserTokens

Parse {animation,transition}-timing-function in CSSPropertyParser with CSSParserTokens

This patch moves the properties animation-timing-function and
transition-timing-function from the LegacyCSSPropertyParser to the
CSSPropertyParser. Some of the logic here is set up as infrastructure
for adding the remaining animation and transition properties. Note
that the logic is still required in the legacy property parser until
the animation and transition shorthands are moved across.

This patch adds a consumeNumberRaw function, which consumes a number
from a CSSParserTokenRange as a double instead of a CSSValue. We may
eventually want to make consumeNumber call into consumeNumberRaw,
but for now I'm leaving these as separate due to potentially subtle
behaviour in calcs and unit type for serialization.

BUG=499780
Committed: https://crrev.com/425c4fdec0debd5dccca66ee9031cb7bebcde865
Cr-Commit-Position: refs/heads/master@{#354983}

[Timothy Loh, 2015-10-19 03:50:37]

timloh@chromium.org changed reviewers:
+ alancutter@chromium.org, rob.buis@samsung.com

[Timothy Loh, 2015-10-19 05:58:37]

There are five patches here (I'm just sending out the first one to save you some
inbox clutter, but all are up for review):

1) https://codereview.chromium.org/1416503002/ (this)
2) https://codereview.chromium.org/1410343002/
3) https://codereview.chromium.org/1410223004/
4) https://codereview.chromium.org/1413543003/
5) https://codereview.chromium.org/1408063004/

[Timothy Loh, 2015-10-19 05:58:37]

There are five patches here (I'm just sending out the first one to save you some
inbox clutter, but all are up for review):

1) https://codereview.chromium.org/1416503002/ (this)
2) https://codereview.chromium.org/1410343002/
3) https://codereview.chromium.org/1410223004/
4) https://codereview.chromium.org/1413543003/
5) https://codereview.chromium.org/1408063004/

[rwlbuis, 2015-10-19 14:12:51]

lgtm with some nits.

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:205: const
CSSParserToken& token = range.peek();
In this case the temp var seems unneeded.

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:924:
RefPtrWillBeRawPtr<CSSPrimitiveValue> steps = consumeInteger(args,
HTMLStandardMode, 1);
Second parameter should be removed by the time you read this :)

[Timothy Loh, 2015-10-20 04:02:25]

Patchset #2 (id:20001) has been deleted

[Timothy Loh, 2015-10-20 04:09:12]

The CQ bit was checked by timloh@chromium.org

[Timothy Loh, 2015-10-20 04:09:13]

The patchset sent to the CQ was uploaded after l-g-t-m from rob.buis@samsung.com
Link to the patchset: https://codereview.chromium.org/1416503002/#ps40001
(title: "address review comments")

[Timothy Loh, 2015-10-20 04:09:35]

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:205: const
CSSParserToken& token = range.peek();
On 2015/10/19 14:12:51, rwlbuis wrote:
> In this case the temp var seems unneeded.

Done.

https://codereview.chromium.org/1416503002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:924:
RefPtrWillBeRawPtr<CSSPrimitiveValue> steps = consumeInteger(args,
HTMLStandardMode, 1);
On 2015/10/19 14:12:51, rwlbuis wrote:
> Second parameter should be removed by the time you read this :)

Changed to consumePositiveInteger

[commit-bot: I haz the power, 2015-10-20 04:09:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416503002/40001

[commit-bot: I haz the power, 2015-10-20 05:18:30]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-10-20 05:19:11]

Patchset 2 (id:??) landed as
https://crrev.com/425c4fdec0debd5dccca66ee9031cb7bebcde865
Cr-Commit-Position: refs/heads/master@{#354983}