Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1410343002: Parse {animation,transition}-{delay,duration} in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years, 2 months ago by Timothy Loh
Modified:
5 years, 2 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@anim1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse {animation,transition}-{delay,duration} in CSSPropertyParser with CSSParserTokens This patch moves the parsing logic for following properties out of the LegacyCSSPropertyParser and into the CSSPropertyParser: animation-delay animation-duration transition-delay transition-duration This logic is still required in the legacy property parser until the animation and transition shorthands are moved across. BUG=499780 Committed: https://crrev.com/5512a574caa535f56baf444b7e1aadecf4f92691 Cr-Commit-Position: refs/heads/master@{#354989}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
rwlbuis
lgtm with one remark. https://codereview.chromium.org/1410343002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right): https://codereview.chromium.org/1410343002/diff/1/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp#newcode344 third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:344: switch (token.unitType()) { Would be ...
5 years, 2 months ago (2015-10-19 17:17:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410343002/20001
5 years, 2 months ago (2015-10-20 05:19:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 05:53:04 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 05:53:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5512a574caa535f56baf444b7e1aadecf4f92691
Cr-Commit-Position: refs/heads/master@{#354989}

Powered by Google App Engine
This is Rietveld 408576698