third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1416503002: Parse {animation,transition}-timing-function in CSSPropertyParser with CSSParserTokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1416503002: Parse {animation,transition}-timing-function in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index 421179ef9cc5b4b0e37fe3924e7965688394136d..d4ba70a0abfc917de11feab0dc578dbcd13d2d5e 100644

--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -976,10 +976,8 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

case CSSPropertyAnimationName:

case CSSPropertyAnimationPlayState:

case CSSPropertyAnimationIterationCount:

- case CSSPropertyAnimationTimingFunction:

case CSSPropertyTransitionDelay:

case CSSPropertyTransitionDuration:

- case CSSPropertyTransitionTimingFunction:

case CSSPropertyTransitionProperty:

parsedValue = parseAnimationPropertyList(propId, unresolvedProperty == CSSPropertyAliasWebkitAnimationName);

break;

@@ -1256,6 +1254,8 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import

case CSSPropertyWebkitColumnGap:

case CSSPropertyWebkitColumnSpan:

case CSSPropertyZoom:

+ case CSSPropertyAnimationTimingFunction:

+ case CSSPropertyTransitionTimingFunction:

validPrimitive = false;

break;

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »