Change file op |ssize_t|s to FileOperationResult

Change file op |ssize_t|s to FileOperationResult

R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3d598cdbcd747e328a928949ef47d57ee4312202

[scottmg, 2015-10-22 22:25:26]

Description was changed from

==========
Change ssize_t to FileOperationResult

BUG=
==========

to

==========
Change file op |ssize_t|s to FileOperationResult

R=mark@chromium.org
==========

[scottmg, 2015-10-22 22:25:26]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-10-22 22:56:18]

LGTM

https://codereview.chromium.org/1416493006/diff/40001/compat/win/sys/types.h
File compat/win/sys/types.h (left):

https://codereview.chromium.org/1416493006/diff/40001/compat/win/sys/types.h#...
compat/win/sys/types.h:28: typedef int64_t ssize_t;
Hmm…wait…these were int64_t/int, but now FileOperationResult is LONG_PTR. Just
confirm that it’s still the right thing.

https://codereview.chromium.org/1416493006/diff/40001/util/file/string_file.h
File util/file/string_file.h (right):

https://codereview.chromium.org/1416493006/diff/40001/util/file/string_file.h...
util/file/string_file.h:53: FileOperationResult Read(void* data, size_t size)
override;
#include file_io.h.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_body_test...
File util/net/http_body_test_util.cc (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_body_test...
util/net/http_body_test_util.cc:34: FileOperationResult bytes_read;
#include file_io.h.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
File util/net/http_transport_mac.mm (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_mac.mm:96: FileOperationResult bytes_read =
file_io.h

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
File util/net/http_transport_win.cc (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_win.cc:26: #include "package.h"
Sort

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_win.cc:177: FileOperationResult bytes_to_write =
file_io.h

[scottmg, 2015-10-22 23:13:40]

https://codereview.chromium.org/1416493006/diff/40001/compat/win/sys/types.h
File compat/win/sys/types.h (left):

https://codereview.chromium.org/1416493006/diff/40001/compat/win/sys/types.h#...
compat/win/sys/types.h:28: typedef int64_t ssize_t;
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> Hmm…wait…these were int64_t/int, but now FileOperationResult is LONG_PTR. Just
> confirm that it’s still the right thing.

Yeah, that was out of a probably-unnecessary desire to avoid including windows.h
here. But file_io.h has to do that anyway.

https://codereview.chromium.org/1416493006/diff/40001/util/file/string_file.h
File util/file/string_file.h (right):

https://codereview.chromium.org/1416493006/diff/40001/util/file/string_file.h...
util/file/string_file.h:53: FileOperationResult Read(void* data, size_t size)
override;
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> #include file_io.h.

Done.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_body_test...
File util/net/http_body_test_util.cc (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_body_test...
util/net/http_body_test_util.cc:34: FileOperationResult bytes_read;
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> #include file_io.h.

Done.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
File util/net/http_transport_mac.mm (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_mac.mm:96: FileOperationResult bytes_read =
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> file_io.h

Done.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
File util/net/http_transport_win.cc (right):

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_win.cc:26: #include "package.h"
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> Sort

Done.

https://codereview.chromium.org/1416493006/diff/40001/util/net/http_transport...
util/net/http_transport_win.cc:177: FileOperationResult bytes_to_write =
On 2015/10/22 22:56:18, Mark Mentovai wrote:
> file_io.h

Done.

[scottmg, 2015-10-22 23:14:24]

Committed patchset #4 (id:60001) manually as
3d598cdbcd747e328a928949ef47d57ee4312202 (presubmit successful).