Change file op |ssize_t|s to FileOperationResult

util/net/http_transport_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/net/http_transport.h"
 
 #include <windows.h>
 #include <winhttp.h>
 
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/scoped_generic.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "util/net/http_body.h"
 #include "package.h"

[Mark Mentovai, 2015/10/22 22:56:18]

Sort

[scottmg, 2015/10/22 23:13:40]

Done.

 
 namespace crashpad {
 
 namespace {
 
 // PLOG doesn't work for messages from WinHTTP, so we need to use
 // FORMAT_MESSAGE_FROM_HMODULE + the dll name manually here.
 void LogErrorWinHttpMessage(const char* extra) {
   DWORD error_code = GetLastError();
   char msgbuf[256];
@@ skipping 130 matching lines @@
 
   // We need the Content-Length up front, so buffer in memory. We should modify
   // the interface to not require this, and then use WinHttpWriteData after
   // WinHttpSendRequest.
   std::vector<uint8_t> post_data;
 
   // Write the body of a POST if any.
   const size_t kBufferSize = 4096;
   for (;;) {
     uint8_t buffer[kBufferSize];
-    ssize_t bytes_to_write =
+    FileOperationResult bytes_to_write =

[Mark Mentovai, 2015/10/22 22:56:18]

file_io.h

[scottmg, 2015/10/22 23:13:40]

Done.

         body_stream()->GetBytesBuffer(buffer, sizeof(buffer));
     if (bytes_to_write == 0)
       break;
     post_data.insert(post_data.end(), buffer, buffer + bytes_to_write);
   }
 
   if (!WinHttpSendRequest(request.get(),
                           WINHTTP_NO_ADDITIONAL_HEADERS,
                           0,
                           &post_data[0],
@@ skipping 52 matching lines @@
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HTTPTransport> HTTPTransport::Create() {
   return scoped_ptr<HTTPTransportWin>(new HTTPTransportWin);
 }
 
 }  // namespace crashpad