Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: util/net/http_body_test_util.cc

Issue 1416493006: Change file op |ssize_t|s to FileOperationResult (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 13 matching lines...) Expand all
24 namespace test { 24 namespace test {
25 25
26 std::string ReadStreamToString(HTTPBodyStream* stream) { 26 std::string ReadStreamToString(HTTPBodyStream* stream) {
27 return ReadStreamToString(stream, 32); 27 return ReadStreamToString(stream, 32);
28 } 28 }
29 29
30 std::string ReadStreamToString(HTTPBodyStream* stream, size_t buffer_size) { 30 std::string ReadStreamToString(HTTPBodyStream* stream, size_t buffer_size) {
31 scoped_ptr<uint8_t[]> buf(new uint8_t[buffer_size]); 31 scoped_ptr<uint8_t[]> buf(new uint8_t[buffer_size]);
32 std::string result; 32 std::string result;
33 33
34 ssize_t bytes_read; 34 FileOperationResult bytes_read;
Mark Mentovai 2015/10/22 22:56:18 #include file_io.h.
scottmg 2015/10/22 23:13:40 Done.
35 while ((bytes_read = stream->GetBytesBuffer(buf.get(), buffer_size)) != 0) { 35 while ((bytes_read = stream->GetBytesBuffer(buf.get(), buffer_size)) != 0) {
36 if (bytes_read < 0) { 36 if (bytes_read < 0) {
37 ADD_FAILURE() << "Failed to read from stream: " << bytes_read; 37 ADD_FAILURE() << "Failed to read from stream: " << bytes_read;
38 return std::string(); 38 return std::string();
39 } 39 }
40 40
41 result.append(reinterpret_cast<char*>(buf.get()), bytes_read); 41 result.append(reinterpret_cast<char*>(buf.get()), bytes_read);
42 } 42 }
43 43
44 return result; 44 return result;
45 } 45 }
46 46
47 } // namespace test 47 } // namespace test
48 } // namespace crashpad 48 } // namespace crashpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698