Issue 14161017: Pepper: Simplify idl_thunk implementation.

Issue 14161017: Pepper: Simplify idl_thunk implementation. (Closed)

Created:
7 years, 8 months ago by teravest

Modified:
7 years, 8 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Simplify idl_thunk implementation. This gets rid of some code duplication, and rewrites functions in thunk files which return void to an alternate, equivalent form. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195180

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1

Patch Set 3 : on_failure comment nit #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -122 lines)			Patch
M	ppapi/generators/idl_thunk.py	View	1 2	1 chunk	+29 lines, -46 lines	0 comments	Download
M	ppapi/thunk/ppb_audio_input_dev_thunk.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	ppapi/thunk/ppb_console_thunk.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	ppapi/thunk/ppb_content_decryptor_private_thunk.cc	View		11 chunks	+50 lines, -40 lines	0 comments	Download
M	ppapi/thunk/ppb_file_io_thunk.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	ppapi/thunk/ppb_find_dev_thunk.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	ppapi/thunk/ppb_gamepad_thunk.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ppapi/thunk/ppb_messaging_thunk.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	ppapi/thunk/ppb_url_loader_thunk.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	ppapi/thunk/ppb_url_loader_trusted_thunk.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download
M	ppapi/thunk/ppb_widget_dev_thunk.cc	View		2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/14161017/diff/4001/ppapi/generators/idl_thunk.py File ppapi/generators/idl_thunk.py (right): https://codereview.chromium.org/14161017/diff/4001/ppapi/generators/idl_thunk.py#newcode301 ppapi/generators/idl_thunk.py:301: raise TGenError('No default value for rtype %s' % ...

7 years, 8 months ago (2013-04-18 15:41:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/14161017/13001

7 years, 8 months ago (2013-04-18 16:14:05 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30129

7 years, 8 months ago (2013-04-18 18:21:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/14161017/13001

7 years, 8 months ago (2013-04-18 18:23:38 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30330

7 years, 8 months ago (2013-04-18 23:38:55 UTC) #6

teravest

7 years, 8 months ago (2013-04-19 14:27:06 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r195180 (presubmit successful).

Expand Messages | Collapse Messages