ppapi/thunk/ppb_url_loader_thunk.cc - Issue 14161017: Pepper: Simplify idl_thunk implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/thunk/ppb_url_loader_thunk.cc

Issue 14161017: Pepper: Simplify idl_thunk implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: on_failure comment nit Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/thunk/ppb_url_loader_thunk.cc

diff --git a/ppapi/thunk/ppb_url_loader_thunk.cc b/ppapi/thunk/ppb_url_loader_thunk.cc

index 8fad53fc8fa0ddd56da22d7893158cea462603a4..7df78b9177cb549199528dc52a193284c439491a 100644

--- a/ppapi/thunk/ppb_url_loader_thunk.cc

+++ b/ppapi/thunk/ppb_url_loader_thunk.cc

@@ -115,8 +115,9 @@ int32_t FinishStreamingToFile(PP_Resource loader,

void Close(PP_Resource loader) {

VLOG(4) << "PPB_URLLoader::Close()";

EnterResource<PPB_URLLoader_API> enter(loader, true);

- if (enter.succeeded())

- enter.object()->Close();

+ if (enter.failed())

+ return;

+ enter.object()->Close();

}

const PPB_URLLoader_1_0 g_ppb_urlloader_thunk_1_0 = {

« no previous file with comments | « ppapi/thunk/ppb_messaging_thunk.cc ('k') | ppapi/thunk/ppb_url_loader_trusted_thunk.cc » ('j') | no next file with comments »